Skip to content

Commit a0dd1e6

Browse files
authored
Merge pull request #8 from ekohl/remove-old-os-support
Drop Debian <= 7, Ubuntu <= 14.04, EL < 7 and SLES < 12
2 parents 25e2eed + f36f556 commit a0dd1e6

File tree

11 files changed

+15
-599
lines changed

11 files changed

+15
-599
lines changed

resources/puppetlabs/lein-ezbake/staging-templates/project_data.yaml.mustache

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ files:
1717
- version
1818
- Gemfile
1919
- Rakefile
20-
- Makefile.erb
2120
- puppet
2221
- install.sh.erb
2322
- ext/fpm.rb
@@ -32,8 +31,6 @@ templates:
3231
target: ext/debian/{{{project}}}.service_file
3332
- source: ext/ezbake.logrotate.conf.erb
3433
target: ext/{{{project}}}.logrotate.conf
35-
- source: ext/ezbake.logrotate-legacy.conf.erb
36-
target: ext/{{{project}}}.logrotate-legacy.conf
3734
- source: ext/ezbake.tmpfiles.conf.erb
3835
target: ext/{{{project}}}.tmpfiles.conf
3936
- source: ext/ezbake.needrestart.conf.erb
@@ -42,8 +39,6 @@ templates:
4239
- ext/redhat/postinst.erb
4340
- ext/redhat/prerm.erb
4441
- ext/redhat/postrm.erb
45-
- ext/redhat/init.erb
46-
- ext/redhat/init.suse.erb
4742
- ext/debian/postrm.erb
4843
- ext/debian/preinst.erb
4944
- ext/debian/prerm.erb
@@ -55,7 +50,6 @@ templates:
5550
- ext/cli_defaults/*.erb
5651
- ext/default.erb
5752
- ext/ezbake-functions.sh.erb
58-
- Makefile.erb
5953
- install.sh.erb
6054
- controller.sh.erb
6155
tar_excludes:

resources/puppetlabs/lein-ezbake/template/global/Makefile.erb

Lines changed: 0 additions & 69 deletions
This file was deleted.

resources/puppetlabs/lein-ezbake/template/global/controller.sh.erb

Lines changed: 7 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,6 @@ if [ ! -d "$basepath/systemd_el" ]; then
2626
cp -r "$basepath/base" "$basepath/systemd_el"
2727
DESTDIR="$basepath/systemd_el" bash install.sh systemd_redhat
2828
fi
29-
if [ ! -d "$basepath/old_el" ]; then
30-
cp -r "$basepath/base" "$basepath/old_el"
31-
DESTDIR="$basepath/old_el" bash install.sh sysv_init_redhat
32-
fi
33-
if [ ! -d "$basepath/old_sles" ]; then
34-
cp -r "$basepath/base" "$basepath/old_sles"
35-
DESTDIR="$basepath/old_sles" bash install.sh sysv_init_suse
36-
fi
37-
38-
<%- rpm_paths = [ "$basepath/systemd_el", "$basepath/old_el", "$basepath/old_sles" ] -%>
3929

4030
# things are only different if we have docs, deb docs get
4131
# installed in an unversioned folder but rpm docs get installed
@@ -47,28 +37,12 @@ if [ -d ext/docs ]; then
4737
cp -r "$basepath/base_deb" "$basepath/systemd_deb"
4838
DESTDIR="$basepath/systemd_deb" bash install.sh systemd_deb
4939
fi
50-
if [ ! -d "$basepath/systemd_notasksmax_deb" ]; then
51-
cp -r "$basepath/base_deb" "$basepath/systemd_notasksmax_deb"
52-
DESTDIR="$basepath/systemd_notasksmax_deb" USE_TASKSMAX=false bash install.sh systemd_deb
53-
fi
54-
if [ ! -d "$basepath/sysvinit_deb" ]; then
55-
cp -r "$basepath/base_deb" "$basepath/sysvinit_deb"
56-
DESTDIR="$basepath/sysvinit_deb" bash install.sh sysv_init_deb
57-
fi
5840
fi
5941
else
6042
if [ ! -d "$basepath/systemd_deb" ]; then
6143
cp -r "$basepath/base" "$basepath/systemd_deb"
6244
DESTDIR="$basepath/systemd_deb" bash install.sh systemd_deb
6345
fi
64-
if [ ! -d "$basepath/systemd_notasksmax_deb" ]; then
65-
cp -r "$basepath/base" "$basepath/systemd_notasksmax_deb"
66-
DESTDIR="$basepath/systemd_notasksmax_deb" USE_TASKSMAX=false bash install.sh systemd_deb
67-
fi
68-
if [ ! -d "$basepath/sysvinit_deb" ]; then
69-
cp -r "$basepath/base" "$basepath/sysvinit_deb"
70-
DESTDIR="$basepath/sysvinit_deb" bash install.sh sysv_init_deb
71-
fi
7246
fi
7347

7448
os=$build_os
@@ -82,33 +56,11 @@ case $os in
8256
# there's no differences in packaging for deb vs ubuntu
8357
# if that changes we'll need to fix this
8458
debian|ubuntu)
85-
if [ "$os_dist" = 'trusty' ]; then
86-
dir="$basepath/sysvinit_deb"
87-
elif [ "$os_dist" = 'jessie' ]; then
88-
# the version of systemd that ships with jessie doesn't
89-
# support TasksMax
90-
dir="$basepath/systemd_notasksmax_deb"
91-
else
92-
dir="$basepath/systemd_deb"
93-
fi
94-
;;
95-
el|redhatfips)
96-
if [ "$os_version" -gt '6' ]; then
97-
dir="$basepath/systemd_el"
98-
else
99-
dir="$basepath/old_el"
100-
fi
59+
dir="$basepath/systemd_deb"
10160
;;
102-
amazon)
61+
amazon|el|redhatfips|sles)
10362
dir="$basepath/systemd_el"
10463
;;
105-
sles)
106-
if [ "$os_version" -gt '11' ]; then
107-
dir="$basepath/systemd_el"
108-
else
109-
dir="$basepath/old_sles"
110-
fi
111-
;;
11264
*)
11365
echo "I have no idea what I'm doing with $os, teach me?" >&2
11466
exit 1
@@ -144,11 +96,7 @@ params+=('--termini-description' "$(printf "$termini_description")")
14496
<% end -%>
14597

14698
<% if EZBake::Config[:logrotate_enabled]-%>
147-
if [[ "$dir" =~ old_ ]]; then
148-
DESTDIR=$dir bash install.sh logrotate_legacy
149-
else
150-
DESTDIR=$dir bash install.sh logrotate
151-
fi
99+
DESTDIR=$dir bash install.sh logrotate
152100
params+=('--logrotate')
153101
<% end -%>
154102

@@ -171,27 +119,23 @@ if [[ "$os" = 'el' || "$os" = 'sles' || "$os" = 'fedora' || "$os" = 'redhatfips'
171119
params+=("<%= dep -%>")
172120
<% end -%>
173121
# get rpm install trigger scripts
174-
<% EZBake::Config[:redhat][:postinst_install_triggers].each do |package, scripts|
175-
rpm_paths.each do |path| -%>
176-
cat > <%=path %>/<%=package%>_postinst_triggers <<EOM
122+
<% EZBake::Config[:redhat][:postinst_install_triggers].each do |package, scripts| -%>
123+
cat > $basepath/systemd_el/<%=package%>_postinst_triggers <<EOM
177124
if [ "\$1" -eq 1 ] ; then
178125
"<%= scripts.join("\n") %>"
179126
:
180127
fi
181128
EOM
182-
<% end -%>
183129
params+=("--rpm-trigger" "'<%=package%>: $dir/<%=package%>_postinst_triggers'")
184130
<% end -%>
185131
# get rpm upgrade trigger scripts
186-
<% EZBake::Config[:redhat][:postinst_upgrade_triggers].each do |package, scripts|
187-
rpm_paths.each do |path| -%>
188-
cat > <%=path %>/<%=package%>_postinst_triggers <<EOM
132+
<% EZBake::Config[:redhat][:postinst_upgrade_triggers].each do |package, scripts| -%>
133+
cat > $basepath/systemd_el/<%=package%>_postinst_triggers <<EOM
189134
if [ "\$1" -gt 1 ] ; then
190135
"<%= scripts.join("\n") %>"
191136
:
192137
fi
193138
EOM
194-
<% end -%>
195139
params+=("--rpm-trigger" "'<%=package%>: $dir/<%=package%>_postinst_triggers'")
196140
<% end -%>
197141
: # Need something in case there are no additional dependencies

resources/puppetlabs/lein-ezbake/template/global/ext/ezbake.logrotate-legacy.conf.erb

Lines changed: 0 additions & 9 deletions
This file was deleted.

resources/puppetlabs/lein-ezbake/template/global/ext/fpm.rb

Lines changed: 5 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,8 @@
66

77
options = OpenStruct.new
88
# settin' some defaults
9-
options.systemd = 0
10-
options.sysvinit = 0
119
options.systemd_el = 0
1210
options.systemd_sles = 0
13-
options.old_el = 0
14-
options.old_sles = 0
1511
options.sles = 0
1612
options.java = 'java-1.8.0-openjdk-headless'
1713
options.release = 1
@@ -140,17 +136,9 @@
140136
if options.sources.empty?
141137
options.sources = case options.operating_system
142138
when :amazon, :fedora, :sles, :el, :redhatfips
143-
if options.operating_system == :el && options.os_version < 7 || options.operating_system == :sles && options.os_version < 12 #sysv rpm platforms
144-
['etc', 'opt', 'var']
145-
else
146-
['etc', 'opt', 'usr', 'var']
147-
end
139+
['etc', 'opt', 'usr', 'var']
148140
when :debian, :ubuntu
149-
if options.dist == 'trusty' #trusty is the only sysv deb we build for right now
150-
['etc', 'opt', 'var']
151-
else
152-
['etc', 'lib', 'opt', 'usr', 'var']
153-
end
141+
['etc', 'lib', 'opt', 'usr', 'var']
154142
else
155143
fail "I don't know what your default sources should be, pass it on the command line!"
156144
end
@@ -177,17 +165,15 @@
177165
fpm_opts << "--rpm-rpmbuild-define '_app_data #{options.app_data}'"
178166

179167
if options.operating_system == :fedora # all supported fedoras are systemd
180-
options.systemd = 1
181168
options.systemd_el = 1
182169
elsif options.operating_system == :amazon
183170
if ! options.is_pe
184171
fpm_opts << "--depends tzdata-java"
185172
options.java = '(java-17-amazon-corretto-headless or java-11-amazon-corretto-headless)'
186173
end
187174

188-
options.systemd = 1
189175
options.systemd_el = 1
190-
elsif options.operating_system == :el && options.os_version >= 7 # systemd el
176+
elsif options.operating_system == :el
191177
if ! options.is_pe
192178
options.java =
193179
if options.os_version == 7
@@ -199,45 +185,26 @@
199185
end
200186
end
201187

202-
options.systemd = 1
203188
options.systemd_el = 1
204-
elsif options.operating_system == :el # old el
205-
options.sysvinit = 1
206-
options.old_el = 1
207-
elsif options.operating_system == :redhatfips && options.os_version >= 7 # systemd redhatfips
208-
options.systemd = 1
189+
elsif options.operating_system == :redhatfips
209190
options.systemd_el = 1
210-
elsif options.operating_system == :sles && options.os_version >= 12 # systemd sles
211-
options.systemd = 1
191+
elsif options.operating_system == :sles
212192
options.systemd_sles = 1
213193
options.sles = 1
214194
if ! options.is_pe
215195
options.java = 'java-11-openjdk-headless'
216196
end
217-
elsif options.operating_system == :sles #old sles
218-
options.sysvinit = 1
219-
options.old_sles = 1
220197
end
221198

222-
fpm_opts << "--rpm-rpmbuild-define '_with_sysvinit #{options.sysvinit}'"
223-
fpm_opts << "--rpm-rpmbuild-define '_with_systemd #{options.systemd}'"
224-
fpm_opts << "--rpm-rpmbuild-define '_old_sles #{options.old_sles}'"
225199
fpm_opts << "--rpm-rpmbuild-define '_systemd_el #{options.systemd_el}'"
226200
fpm_opts << "--rpm-rpmbuild-define '_systemd_sles #{options.systemd_sles}'"
227-
fpm_opts << "--rpm-rpmbuild-define '_old_el #{options.old_el}'"
228201
fpm_opts << "--rpm-rpmbuild-define '_sysconfdir /etc'"
229202
fpm_opts << "--rpm-rpmbuild-define '_prefix #{options.app_prefix}'"
230203
fpm_opts << "--rpm-rpmbuild-define '_rundir /var/run'"
231204
fpm_opts << "--rpm-rpmbuild-define '__jar_repack 0'"
232205

233206
shared_opts << "--rpm-dist #{options.dist}"
234207

235-
if options.old_el == 1
236-
fpm_opts << "--depends chkconfig"
237-
elsif options.old_sles == 1
238-
fpm_opts << "--depends aaa_base"
239-
end
240-
241208
if options.systemd_el == 1
242209
fpm_opts << "--depends systemd"
243210
end
@@ -275,10 +242,7 @@
275242
fpm_opts << "--rpm-auto-add-exclude-directories /opt/puppetlabs/server/data"
276243
fpm_opts << "--rpm-auto-add-exclude-directories /usr/lib/systemd"
277244
fpm_opts << "--rpm-auto-add-exclude-directories /usr/lib/systemd/system"
278-
fpm_opts << "--rpm-auto-add-exclude-directories /etc/init.d"
279-
fpm_opts << "--rpm-auto-add-exclude-directories /etc/rc.d"
280245
fpm_opts << "--rpm-auto-add-exclude-directories /etc/logrotate.d"
281-
fpm_opts << "--rpm-auto-add-exclude-directories /etc/rc.d/init.d"
282246
fpm_opts << "--rpm-auto-add-exclude-directories /usr/lib/tmpfiles.d"
283247
fpm_opts << "--rpm-auto-add-exclude-directories /var/log/puppetlabs"
284248
fpm_opts << "--rpm-auto-add-exclude-directories /var/run/puppetlabs"

0 commit comments

Comments
 (0)