Merge pull request #106 from bastelfreak/argh

voxpupuli-rubocop: Update 4.2.0->5.0.0

Author: bastelfreak

.rubocop_todo.yml

@@ -1,11 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-auto-gen-timestamp`
-# using RuboCop version 1.79.2.
+# using RuboCop version 1.81.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleAlignWith, Severity.
+# SupportedStylesAlignWith: start_of_line, begin
+Layout/BeginEndAlignment:
+  Exclude:
+    - 'lib/bolt/plugin.rb'
+
 # Offense count: 14
 # This cop supports safe autocorrection (--autocorrect).
 Layout/ClosingHeredocIndentation:
@@ -308,7 +316,6 @@ RSpec/Be:
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
 RSpec/BeEmpty:
   Exclude:
     - 'spec/unit/project_manager/module_migrator_spec.rb'
@@ -435,7 +442,7 @@ RSpec/ImplicitSubject:
   Enabled: false
 
 # Offense count: 71
-# This cop supports safe autocorrection (--autocorrect).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/IncludeExamples:
   Enabled: false
 
@@ -456,6 +463,7 @@ RSpec/InstanceVariable:
   Enabled: false
 
 # Offense count: 11
+# This cop supports safe autocorrection (--autocorrect).
 RSpec/IteratedExpectation:
   Exclude:
     - 'spec/integration/parallel_spec.rb'
@@ -607,7 +615,6 @@ RSpec/RepeatedExampleGroupDescription:
 
 # Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
 RSpec/ScatteredLet:
   Exclude:
     - 'bolt-modules/boltlib/spec/functions/set_resources_spec.rb'
@@ -623,14 +630,11 @@ RSpec/SortMetadata:
     - 'spec/integration/inventory_spec.rb'
 
 # Offense count: 78
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
-# Include: **/*_spec.rb
+# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata.
 RSpec/SpecFilePathFormat:
   Enabled: false
 
 # Offense count: 3
-# Configuration parameters: Include.
-# Include: **/*_spec*rb*, **/spec/**/*
 RSpec/SpecFilePathSuffix:
   Exclude:
     - 'bolt-modules/boltlib/spec/functions/puppetdb_fact.rb'
@@ -1112,7 +1116,7 @@ Style/TernaryParentheses:
 # Offense count: 522
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+# SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
 Style/TrailingCommaInArguments:
   Enabled: false
 

bolt-modules/boltlib/lib/puppet/functions/apply_prep.rb

@@ -71,8 +71,8 @@ def run_task(targets, task, args = {}, options = {})
   #
   private def agent?(target)
     inventory.features(target).include?('puppet-agent') ||
-    executor.transport(target.transport).provided_features.include?('puppet-agent') ||
-    target.remote?
+      executor.transport(target.transport).provided_features.include?('puppet-agent') ||
+      target.remote?
   end
 
   # Generate the plugin tarball.

dev-resources/bump_mods.rb

@@ -7,7 +7,7 @@
 require 'rss'
 
 def parse_puppetfile_get_mod_versions
-  module_re = /^mod 'puppetlabs-([a-z_\-]+)', *'([0-9.]+)'$/i
+  module_re = /^mod 'puppetlabs-([a-z_-]+)', *'([0-9.]+)'$/i
   versions = {}
   File.foreach('Puppetfile') do |line|
     match = module_re.match(line)
@@ -40,7 +40,7 @@ def latest_version_for_module(mod)
 end
 
 def puppetfile_set_mod_versions!(versions_new)
-  module_re = /^mod 'puppetlabs-([a-z_\-]+)', *'([0-9.]+)'$/i
+  module_re = /^mod 'puppetlabs-([a-z_-]+)', *'([0-9.]+)'$/i
   lines = File.open('Puppetfile').readlines
 
   # update lines

openbolt.gemspec

@@ -69,7 +69,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "octokit", ">= 4.0", "< 9"
   spec.add_development_dependency "rake", ">= 12.0", "< 14"
   spec.add_development_dependency "rspec", ">= 3.0", "< 4"
-  spec.add_development_dependency 'voxpupuli-rubocop', '~> 4.2.0'
+  spec.add_development_dependency 'voxpupuli-rubocop', '~> 5.0.0'
 
   platform = RUBY_PLATFORM
   if platform =~ /mingw|mswin/