rubocop: autofix

Author: bastelfreak

.github/workflows/tests.yaml

@@ -34,7 +34,9 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-24.04, windows-latest]
-        ruby: ${{ fromJSON(needs.rubocop_and_matrix.outputs.ruby) }}
+        # don't generate the matrix dynamically until we switch from puppet to openvox, puppet fails on Ruby 3.4
+        #ruby: ${{ fromJSON(needs.rubocop_and_matrix.outputs.ruby) }}
+        ruby: ['3.2', '3.3']
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout repository

spec/integration/inventory_spec.rb

@@ -18,29 +18,29 @@
 
   let(:inventory) do
     { targets: [
-      { uri: conn[:host],
-        config: {
-          transport: conn[:protocol],
-          conn[:protocol] => {
-            user: conn[:user],
-            port: conn[:port],
-            'connect-timeout': conn[:'connect-timeout'] || 120
-          }
-        } },
-      { name: 'uriless',
-        config: {
-          transport: conn[:protocol],
-          conn[:protocol] => {
-            host: conn[:host],
-            user: conn[:user],
-            port: conn[:port]
-          }
-        } },
-      { name: 'hostless',
-        config: {
-          transport: conn[:protocol]
-        } }
-    ],
+        { uri: conn[:host],
+          config: {
+            transport: conn[:protocol],
+            conn[:protocol] => {
+              user: conn[:user],
+              port: conn[:port],
+              'connect-timeout': conn[:'connect-timeout'] || 120
+            }
+          } },
+        { name: 'uriless',
+          config: {
+            transport: conn[:protocol],
+            conn[:protocol] => {
+              host: conn[:host],
+              user: conn[:user],
+              port: conn[:port]
+            }
+          } },
+        { name: 'hostless',
+          config: {
+            transport: conn[:protocol]
+          } }
+      ],
       groups: [{
         name: "group1",
         targets: [

spec/integration/jail_spec.rb

@@ -85,8 +85,7 @@
     let(:default_inv) do
       {
         'config' => {
-          'jail' => {
-          }
+          'jail' => {}
         }
       }
     end
@@ -102,8 +101,7 @@
     let(:run_as_conf) do
       {
         'config' => {
-          'jail' => {
-          }
+          'jail' => {}
         }
       }
     end

spec/integration/puppetdb/client_spec.rb

@@ -126,9 +126,9 @@
 
     def facts_hash
       { 'node1' => {
-        'foo' => 'bar',
+          'foo' => 'bar',
         'name' => 'node1'
-      },
+        },
         'node2' => {
           'foo' => 'bar',
           '1' => 'the loneliest number',

spec/integration/remote_spec.rb

@@ -14,28 +14,28 @@
   let(:conn) { conn_info('ssh') }
   let(:inventory) do
     { 'targets' => [
-      { 'uri' => conn[:host],
-        'config' => {
-          'transport' => conn[:protocol],
-          conn[:protocol] => {
-            'user' => conn[:user],
-            'port' => conn[:port],
-            'password' => conn[:password]
-          }
-        } },
-      { 'uri' => 'remote://simple.example.com',
-        'config' => {
-          'remote' => {
-            'run-on' => conn[:host],
-            'token' => 'token_val'
-          }
-        } },
-      { 'uri' => 'https://www.example.com',
-        'config' => {
-          'transport' => 'remote',
-          'remote' => { 'run-on': conn[:host] }
-        } }
-    ],
+        { 'uri' => conn[:host],
+          'config' => {
+            'transport' => conn[:protocol],
+            conn[:protocol] => {
+              'user' => conn[:user],
+              'port' => conn[:port],
+              'password' => conn[:password]
+            }
+          } },
+        { 'uri' => 'remote://simple.example.com',
+          'config' => {
+            'remote' => {
+              'run-on' => conn[:host],
+              'token' => 'token_val'
+            }
+          } },
+        { 'uri' => 'https://www.example.com',
+          'config' => {
+            'transport' => 'remote',
+            'remote' => { 'run-on': conn[:host] }
+          } }
+      ],
       'config' => {
         'ssh' => { 'host-key-check' => false },
         'winrm' => { 'ssl' => false, 'ssl-verify' => false }

spec/lib/bolt_spec/puppetdb.rb

@@ -31,22 +31,20 @@ def make_command(command:, version:, payload:, wait: nil)
     end
 
     def replace_facts(certname, facts, wait: nil)
-      make_command(command: 'replace facts', version: 5, payload: {
+      make_command(command: 'replace facts', version: 5, payload:
+                   {
                      certname: certname,
                      environment: 'production',
                      producer_timestamp: Time.now.iso8601(3),
                      producer: 'bolt',
-                     values: facts
+                    values: facts
                    },
                    wait: wait)
     end
 
     def deactivate_node(certname, wait: nil)
-      make_command(command: 'deactivate node', version: 3, payload: {
-                     certname: certname,
-                     producer_timestamp: Time.now.iso8601(3)
-                   },
-                   wait: wait)
+      make_command(command: 'deactivate node', version: 3,
+                   payload: { certname: certname, producer_timestamp: Time.now.iso8601(3) }, wait: wait)
     end
 
     def push_facts(facts_hash)

spec/unit/logger_spec.rb

@@ -53,8 +53,7 @@ def initialize(*args)
   describe '::configure' do
     let(:appenders) {
       {
-        'file:/bolt.log' => {
-        },
+        'file:/bolt.log' => {},
         'file:/debug.log' => {
           level: :debug,
           append: false