Merge pull request #7 from bastelfreak/ci

CI: Run unit tests on all Ruby 2.7-3.3

Author: bastelfreak

.github/workflows/unit.yaml

@@ -1,30 +1,24 @@
+---
 name: Unit tests
 
 on:
-  pull_request:
-    types: [opened, reopened, edited, synchronize]
-    paths:
-      - .github/workflows/unit.yaml
-      - bolt.gemspec
-      - Gemfile
-      - Puppetfile
-      - bolt-modules/**
-      - lib/bolt/**
-      - libexec/**
-      - rakelib/tests.rake
-      - spec/**
+  pull_request: {}
+  push:
+    branches:
+      - main
 
-env:
-  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+permissions:
+  contents: read
 
 jobs:
 
   unit:
-    name: Unit
+    name: "Ruby ${{ matrix.ruby }}"
     strategy:
+      fail-fast: false
       matrix:
-        os: [ubuntu-22.04, windows-latest]
-        ruby: [3.1]
+        os: [ubuntu-24.04, windows-latest]
+        ruby: ['2.7', '3.0', '3.1', '3.2', '3.3']
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout repository
@@ -34,8 +28,8 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
-      - name: Update gems
-        run: bundle update
+      - name: Output Ruby Environment
+        run: bundle env
       - name: Cache modules
         id: modules
         uses: actions/cache@v4
@@ -47,3 +41,11 @@ jobs:
         run: bundle exec r10k puppetfile install
       - name: Unit tests
         run: bundle exec rake tests:unit
+
+  tests:
+    needs:
+      - unit
+    runs-on: ubuntu-24.04
+    name: Test suite
+    steps:
+      - run: echo Test suite complete

.gitignore

@@ -21,7 +21,8 @@
 
 ## Environment normalization:
 /.bundle/
-/vendor/bundle
+/vendor/
+/.vendor/
 /lib/bundler/man/
 
 Gemfile.lock

spec/unit/outputter/human_spec.rb

@@ -273,7 +273,15 @@
 
   it "prints empty results from a plan" do
     outputter.print_plan_result(Bolt::PlanResult.new([], 'success'))
-    expect(output.string).to eq("[]\n")
+    # json 2.8 changed the array/hash formatting. Ruby 3.0 ships json 2.8+, Ruby 2.7 has an older version
+    # interestingly, in openvox the default is the old behaviour, in bolt it's the new behaviour
+    # https://github.com/OpenVoxProject/puppet/pull/132
+    major_version = RUBY_VERSION.split('.').first.to_i
+    if major_version == 2
+      expect(output.string).to eq("[\n\n]\n")
+    else
+      expect(output.string).to eq("[]\n")
+    end
   end
 
   it "formats unwrapped ExecutionResult from a plan" do