adjust rubocop configuration

Author: bastelfreak

.rubocop.yml

@@ -10,11 +10,9 @@ AllCops:
 
 require:
   - rubocop-performance
+  - rubocop-rake
   - rubocop-rspec
 
-plugins:
-  - rubocop-capybara
-
 Layout/LineLength:
   Enabled: false
 

.rubocop_todo.yml

@@ -1,41 +1,80 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-auto-gen-timestamp`
-# using RuboCop version 1.78.0.
+# using RuboCop version 1.84.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Configuration parameters: EnforcedStyle, AllowedPatterns, ForbiddenIdentifiers, ForbiddenPatterns.
-# SupportedStyles: snake_case, camelCase
-# ForbiddenIdentifiers: __id__, __send__
-Naming/MethodName:
-  Exclude:
-    - 'spec/mocks/win32ole.rb'
-    - 'spec/mocks/ffi.rb'
-    - 'spec/facter/util/windows/network_utils_spec.rb'
-
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Performance/RegexpMatch:
   Exclude:
     - 'install.rb'
 
+# Offense count: 1
+RSpec/IdenticalEqualityAssertion:
+  Exclude:
+    - 'spec/facter/util/resolvers/ssh_helper_spec.rb'
+
+# Offense count: 50
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
+  Enabled: false
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/MatchArray:
+  Exclude:
+    - 'spec/facter/facts/solaris/ldom_spec.rb'
+
+# Offense count: 18
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/custom_facts/core/execution/fact_manager_spec.rb'
+    - 'spec/custom_facts/core/resolvable_spec.rb'
+    - 'spec/custom_facts/core/suitable_spec.rb'
+    - 'spec/custom_facts/util/collection_spec.rb'
+    - 'spec/custom_facts/util/parser_spec.rb'
+    - 'spec/facter/resolvers/ec2_spec.rb'
+
+# Offense count: 128
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/ReceiveMessages:
+  Enabled: false
+
 # Offense count: 70
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
+# Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata, InflectorPath, EnforcedInflector.
+# SupportedInflectors: default, active_support
+RSpec/SpecFilePathFormat:
   Enabled: false
 
+# Offense count: 18
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/VerifiedDoubleReference:
+  Exclude:
+    - 'spec/facter/resolvers/aix/serialnumber_spec.rb'
+    - 'spec/facter/resolvers/bsd/ffi_helper_spec.rb'
+    - 'spec/facter/resolvers/solaris/mountpoints_spec.rb'
+    - 'spec/facter/resolvers/windows/fips_spec.rb'
+    - 'spec/facter/resolvers/windows/netkvm_spec.rb'
+    - 'spec/facter/resolvers/windows/networking_spec.rb'
+    - 'spec/facter/resolvers/windows/product_release_spec.rb'
+    - 'spec/facter/resolvers/windows/virtualization_spec.rb'
+    - 'spec/facter/util/windows/network_utils_spec.rb'
+    - 'spec/framework/core/options/option_store_spec.rb'
+    - 'spec/framework/core/options_spec.rb'
+
 # Offense count: 14
 Style/ClassVars:
   Exclude:
     - 'lib/facter/framework/logging/logger.rb'
     - 'spec/custom_facts/puppetlabs_spec/files.rb'
     - 'spec/framework/logging/logger_spec.rb'
 
-# Offense count: 981
+# Offense count: 985
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false

openfact.gemspec

@@ -40,6 +40,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 1.28', '< 1.85'
   spec.add_development_dependency 'rubocop-performance', '~> 1.5'
+  spec.add_development_dependency 'rubocop-rake', '< 1'
   spec.add_development_dependency 'rubocop-rspec', '>= 2.10', '< 4'
   spec.add_development_dependency 'simplecov', '~> 0.17'
   spec.add_development_dependency 'sys-filesystem', '~> 1.4'

spec/facter/facts/solaris/ldom_spec.rb

@@ -42,8 +42,21 @@
       end
 
       it 'returns virtual fact as ldom' do
-        expect(fact.call_the_resolver).to contain_exactly(an_object_having_attributes(name: 'ldom', value: value, type: :core), an_object_having_attributes(name: 'ldom_domainchassis', value: 'AK00358110', type: :legacy), an_object_having_attributes(name: 'ldom_domaincontrol', value: 'opdx-a0-sun2', type: :legacy), an_object_having_attributes(name: 'ldom_domainname', value: 'sol11-9', type: :legacy), an_object_having_attributes(name: 'ldom_domainrole_control', value: 'false', type: :legacy), an_object_having_attributes(name: 'ldom_domainrole_impl', value: 'LDoms', type: :legacy), an_object_having_attributes(name: 'ldom_domainrole_io', value: 'false', type: :legacy), an_object_having_attributes(name: 'ldom_domainrole_root', value: 'false', type: :legacy), an_object_having_attributes(name: 'ldom_domainrole_service', value: 'false', type: :legacy), an_object_having_attributes(name: 'ldom_domainuuid', value: 'd7a3a4df-ce8c-47a9-b396-cb5a5f30c0b2',
-                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     type: :legacy))
+        expect(fact.call_the_resolver).to match_array(
+          [
+            an_object_having_attributes(name: 'ldom', value: value, type: :core),
+            an_object_having_attributes(name: 'ldom_domainchassis', value: 'AK00358110', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domaincontrol', value: 'opdx-a0-sun2', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainname', value: 'sol11-9', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainrole_control', value: 'false', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainrole_impl', value: 'LDoms', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainrole_io', value: 'false', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainrole_root', value: 'false', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainrole_service', value: 'false', type: :legacy),
+            an_object_having_attributes(name: 'ldom_domainuuid', value: 'd7a3a4df-ce8c-47a9-b396-cb5a5f30c0b2',
+                                        type: :legacy)
+          ]
+        )
       end
     end