-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Summary
ldapname on custom facts is deprecated and logs a warning that it will be removed.
Evidence
lib/facter/custom_facts/util/fact.rb:21marksldapnameaccessor as deprecated.lib/facter/custom_facts/util/fact.rb:146marksextract_ldapname_option!as deprecated.lib/facter/custom_facts/util/fact.rb:150logs:ldapname is deprecated and will be removed in a future version.spec/custom_facts/util/fact_spec.rb:53asserts the deprecation warning.
Proposed Change
- Remove
attr_accessor :ldapnamefromFacter::Util::Fact. - Remove option extraction for
:ldapname. - Remove collection-level forwarding to
extract_ldapname_option!(lib/facter/custom_facts/util/collection.rb:166).
Compatibility / Risk
- Medium risk for custom facts that still pass
ldapname:or readfact.ldapname. - Behavior is already flagged at runtime; this is a planned hard removal.
Implementation Notes
- Remove warning path after API removal.
- Update tests that assert warning behavior to assert unsupported option behavior.
- Document migration: use fact name and modern custom fact metadata instead of LDAP-specific aliasing.
Acceptance Criteria
ldapnameis no longer accepted as a fact option.Facter::Util::Factno longer exposesldapname.- No deprecation warning about
ldapnameremains in runtime logs.
Suggested Tests
- Unit test that
ldapname:option is rejected or ignored per final policy. - Unit test that no
ldapnameaccessor is present.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Deprecated