-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Summary
Facter::Core::Execution.exec is explicitly deprecated in favor of Facter::Core::Execution.execute.
Evidence
lib/facter/custom_facts/core/execution.rb:97marksexecas deprecated with replacement guidance (Use #{execute} instead).lib/facter/custom_facts/core/execution.rb:100delegatesexecto@@impl.execute(command, on_fail: nil).spec/custom_facts/core/execution_spec.rb:39verifies#execdelegation behavior.
Proposed Change
- Remove
Facter::Core::Execution.exec. - Keep
executeas the public command execution API.
Compatibility / Risk
- Medium risk for custom facts/plugins calling
Facter::Core::Execution.exec. - Migration is direct and low-complexity (
exec(cmd)->execute(cmd, on_fail: nil)as needed).
Implementation Notes
- Update internal call sites first.
- Update public API docs/examples to only mention
execute. - If needed, include a clear release-note migration snippet.
Acceptance Criteria
Facter::Core::Execution.execno longer exists.- Internal code uses
executeonly. - Test suite no longer expects
execdelegation.
Suggested Tests
- Unit tests for
executesuccess/failure behavior (on_fail, timeout, logger). - Negative API test for removed
execentry point if compatibility policy requires explicit error.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Deprecated