-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Summary
Facter::Util::Resolution publicly exposes compatibility command-execution methods and marks that compatibility block as deprecated.
Evidence
lib/facter/custom_facts/util/resolution.rb:30marks compatibility exposure as deprecated.lib/facter/custom_facts/util/resolution.rb:33exposespublic :which, :execfromFacter::Core::Execution.- Inline comment states this was a compatibility bridge after extraction to
Facter::Core::Execution.
Proposed Change
- Remove deprecated class-level exposure of
whichandexeconFacter::Util::Resolution. - Require callers to use
Facter::Core::Executiondirectly.
Compatibility / Risk
- Medium risk for older custom facts invoking
Facter::Util::Resolution.exec/which. execremoval aligns with separate deprecation issue forFacter::Core::Execution.exec([Deprecation]Facter::Core::Execution.exec#88).
Implementation Notes
- Audit internal and fixture call sites for
Facter::Util::Resolution.exec/which. - Keep
with_envexposure only if still required and intentionally supported. - Coordinate rollout with
Execution.execremoval to avoid partial breakage.
Acceptance Criteria
Facter::Util::Resolutionno longer exposes deprecatedexec/whichcompatibility methods.- No internal code path depends on these compatibility methods.
- Documentation directs consumers to supported execution APIs.
Suggested Tests
- Custom fact execution tests using supported API paths.
- Negative tests for removed compatibility methods if explicit failure behavior is desired.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Deprecated