Standardize rake tasks

Author: nmburgan

Rakefile

@@ -5,9 +5,28 @@ require 'rake'
 require 'rubygems'
 require 'rubygems/package_task'
 
-def run_command(cmd)
-  output, status = Open3.capture2e(cmd)
-  abort "Command failed! Command: #{cmd}, Output: #{output}" unless status.exitstatus.zero?
+RED = "\033[31m"
+GREEN = "\033[32m"
+RESET = "\033[0m"
+
+def run_command(cmd, silent: true, print_command: false, report_status: false)
+  puts "#{GREEN}Running #{cmd}#{RESET}" if print_command
+  output = ''
+  Open3.popen2e(cmd) do |_stdin, stdout_stderr, thread|
+    stdout_stderr.each do |line|
+      puts line unless silent
+      output += line
+    end
+    exitcode = thread.value.exitstatus
+    unless exitcode.zero?
+      err = "#{RED}Command failed! Command: #{cmd}, Exit code: #{exitcode}"
+      # Print details if we were running silent
+      err += "\nOutput:\n#{output}" if silent
+      err += RESET
+      abort err
+    end
+    puts "#{GREEN}Command finished with status #{exitcode}#{RESET}" if report_status
+  end
   output.chomp
 end
 

tasks/tag.rake

@@ -1,34 +1,34 @@
 namespace :vox do
-    desc 'Update version, create tag, and push to origin'
-    task :tag, [:tag] do |_, args|
-        abort 'You must provide a tag.' if args[:tag].nil? || args[:tag].empty?
-        version = args[:tag]
-        abort "#{version} does not appear to be a valid version string in x.y.z format" unless Gem::Version.correct?(version)
+  desc 'Update version, create tag, and push to origin'
+  task :tag, [:tag] do |_, args|
+    abort 'You must provide a tag.' if args[:tag].nil? || args[:tag].empty?
+    version = args[:tag]
+    abort "#{version} does not appear to be a valid version string in x.y.z format" unless Gem::Version.correct?(version)
 
-        # Update lib/puppet/version.rb and puppet.gemspec
-        puts "Setting version to #{version}"
-        data = File.read('lib/puppet/version.rb')
-        data = data.sub(/PUPPETVERSION = '\d+\.\d+\.\d+'/, "PUPPETVERSION = '#{version}'")
-        File.write('lib/puppet/version.rb', data)
-        data = File.read('puppet.gemspec')
-        data = data.sub(/spec.version = "\d+\.\d+\.\d+"/, "spec.version = \"#{version}\"")
-        File.write('puppet.gemspec', data)
-        run_command("git add lib/puppet/version.rb && git add puppet.gemspec && git commit -m 'Set version to #{version}'", true)
+    # Update lib/puppet/version.rb and puppet.gemspec
+    puts "Setting version to #{version}"
+    data = File.read('lib/puppet/version.rb')
+    data = data.sub(/PUPPETVERSION = '\d+\.\d+\.\d+'/, "PUPPETVERSION = '#{version}'")
+    File.write('lib/puppet/version.rb', data)
+    data = File.read('puppet.gemspec')
+    data = data.sub(/spec.version = "\d+\.\d+\.\d+"/, "spec.version = \"#{version}\"")
+    File.write('puppet.gemspec', data)
+    run_command("git add lib/puppet/version.rb && git add puppet.gemspec && git commit -m 'Set version to #{version}'")
 
-        # Run git command to get short SHA and one line description of the commit on HEAD
-        branch = run_command('git rev-parse --abbrev-ref HEAD', true)
-        sha = run_command('git rev-parse --short HEAD', true)
-        msg = run_command('git log -n 1 --pretty=%B', true)
+    # Run git command to get short SHA and one line description of the commit on HEAD
+    branch = run_command('git rev-parse --abbrev-ref HEAD')
+    sha = run_command('git rev-parse --short HEAD')
+    msg = run_command('git log -n 1 --pretty=%B')
 
-        puts "Branch: #{branch}"
-        puts "SHA: #{sha}"
-        puts "Commit: #{msg}"
+    puts "Branch: #{branch}"
+    puts "SHA: #{sha}"
+    puts "Commit: #{msg}"
 
-        run_command("git tag -a #{version} -m '#{version}'")
+    run_command("git tag -a #{version} -m '#{version}'")
 
-        unless !ENV['NOPUSH'].nil?
-            puts "Pushing to origin"
-            run_command("git push origin && git push origin #{version}")
-        end
+    unless !ENV['NOPUSH'].nil?
+      puts "Pushing to origin"
+      run_command("git push origin && git push origin #{version}")
     end
-end
+  end
+end