Merge pull request #87 from OpenVoxProject/backport-63-to-7.x

Add implementation fact to agent and server

Author: bastelfreak

lib/puppet/node/facts.rb

@@ -27,6 +27,7 @@ def save(instance, key = nil, options={})
   attr_accessor :name, :values, :timestamp
 
   def add_local_facts
+    values["implementation"] = Puppet.implementation
     values["clientcert"] = Puppet.settings[:certname]
     values["clientversion"] = Puppet.version.to_s
     values["clientnoop"] = Puppet.settings[:noop]

lib/puppet/node/server_facts.rb

@@ -4,6 +4,9 @@ class Puppet::Node::ServerFacts
   def self.load
     server_facts = {}
 
+    # Add implementation information
+    server_facts["implementation"] = Puppet.implementation
+
     # Add our server Puppet Enterprise version, if available.
     pe_version_file = '/opt/puppetlabs/server/pe_version'
     if File.readable?(pe_version_file) and !File.zero?(pe_version_file)

lib/puppet/version.rb

@@ -7,6 +7,7 @@
 
 module Puppet
   PUPPETVERSION = '7.36.1'
+  IMPLEMENTATION = 'openvox'
 
   ##
   # version is a public API method intended to always provide a fast and
@@ -73,6 +74,10 @@ def self.version=(version)
     @puppet_version = version
   end
 
+  def self.implementation
+    IMPLEMENTATION
+  end
+
   ##
   # read_version_file reads the content of the "VERSION" file that lives in the
   # same directory as this source code file.

spec/unit/node/facts_spec.rb

@@ -35,6 +35,12 @@
       @facts.add_local_facts
       expect(@facts.values["environment"]).to eq("foo")
     end
+
+    it "adds the implementation fact" do
+      @facts.add_local_facts
+      expect(@facts.values).to include("implementation")
+      expect(@facts.values["implementation"]).to eq("openvox")
+    end
   end
 
   describe "when sanitizing facts" do