Skip to content

[Deprecation] CLI Benchmark Legacy Options (--rand-perc, --threads Alias) #211

@silug

Description

@silug

Summary

Benchmark CLI still includes deprecated options/aliases.

Evidence

  • src/puppetlabs/puppetdb/cli/benchmark.clj:638 errors explicitly: --rand-perc is deprecated; use --rand-catalogs and/or --rand-facts.
  • src/puppetlabs/puppetdb/cli/benchmark.clj:717 help marks --rand-perc as deprecated.
  • src/puppetlabs/puppetdb/cli/benchmark.clj:743 marks --threads as deprecated alias for --senders.

Proposed OpenVoxDB 9 Change

  • Remove --rand-perc option entirely.
  • Remove --threads alias and keep --senders only.

Compatibility / Risk

  • Low risk; benchmark CLI is niche and migration is straightforward.

Implementation Notes

  • Keep CLI error/help text focused on supported flags only.
  • Update docs/examples/scripts that still reference deprecated options.

Acceptance Criteria

  • Deprecated benchmark flags are no longer accepted.
  • Help output does not list deprecated options.
  • Tests/docs updated to supported flags.

Suggested Tests

  • CLI parsing tests for supported benchmark flags.
  • Negative tests for removed deprecated flags.

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationThis issue pertains to an item/topic which has been deprecated

    Type

    No type

    Projects

    Status

    Deprecated

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions