fix: improve URL validation for attachment retrieval

hnccox · hnccox · commit 585cf90a5c5a · 2025-07-15T14:34:47.000+02:00
diff --git a/src/OpenWOO/Models/BijlageEntity.php b/src/OpenWOO/Models/BijlageEntity.php
@@ -42,7 +42,7 @@ protected function getAttachmentURL(): string
         // First try by using the 'woo_Bijlage_id' field.
         $url = \wp_get_attachment_url($this->getAttachmentObjectID()) ?: '';
 
-        if ($url !== false) {
+        if (is_string($url) && 0 < strlen($url)) {
             return $url;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected function getAttachmentURL(): string`
`42`	`42`	`// First try by using the 'woo_Bijlage_id' field.`
`43`	`43`	`$url = \wp_get_attachment_url($this->getAttachmentObjectID()) ?: '';`
`44`	`44`
`45`		`- if ($url !== false) {`
	`45`	`+ if (is_string($url) && 0 < strlen($url)) {`
`46`	`46`	`return $url;`
`47`	`47`	`}`
`48`	`48`