(refactor): add mime mapping when retrieving the extension in InformationObject trait

Author: Mike van den Hoek

src/Entities/Enkelvoudiginformatieobject.php

@@ -92,9 +92,20 @@ public function formatType(): string
             return '';
         }
 
-        $parts = explode('/', $type);
+        $mimeMap = [
+            'application/pdf' => 'pdf',
+            'application/msword' => 'doc',
+            'application/vnd.openxmlformats-officedocument.wordprocessingml.document' => 'docx',
+            'application/vnd.ms-excel' => 'xls',
+            'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' => 'xlsx',
+            'text/plain' => 'txt',
+            'text/csv' => 'csv',
+            'text/html' => 'html',
+            'application/json' => 'json',
+            'application/xml' => 'xml',
+        ];
 
-        return end($parts) ?: '';
+        return $mimeMap[$type] ?? '';
     }
 
     public function formattedMetaData(): string

src/Routing/Controllers/ZaakInformationObjectRoutingController.php

@@ -144,12 +144,19 @@ protected function getExtension(string $file): string
         $finfo = finfo_open(FILEINFO_MIME_TYPE);
         $mimeType = finfo_file($finfo, $file);
 
-        if (! $mimeType) {
-            return '';
-        }
-
-        $parts = explode('/', $mimeType);
+        $mimeMap = [
+            'application/pdf' => 'pdf',
+            'application/msword' => 'doc',
+            'application/vnd.openxmlformats-officedocument.wordprocessingml.document' => 'docx',
+            'application/vnd.ms-excel' => 'xls',
+            'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' => 'xlsx',
+            'text/plain' => 'txt',
+            'text/csv' => 'csv',
+            'text/html' => 'html',
+            'application/json' => 'json',
+            'application/xml' => 'xml',
+        ];
 
-        return end($parts) ?: '';
+        return $mimeMap[$mimeType] ?? '';
     }
 }

src/Traits/InformationObject.php

@@ -10,7 +10,7 @@ public function informationObjectToBase64(string $url): string
     {
         try {
             $file = file_get_contents($url, false, $this->streamContext());
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             $file = '';
         }
 
@@ -32,9 +32,21 @@ public function getContentLength(string $url): string
     public function getExtension(string $url): string
     {
         $type = $this->getContentType($url);
-        $parts = explode('/', $type);
 
-        return end($parts);
+        $mimeMap = [
+            'application/pdf' => 'pdf',
+            'application/msword' => 'doc',
+            'application/vnd.openxmlformats-officedocument.wordprocessingml.document' => 'docx',
+            'application/vnd.ms-excel' => 'xls',
+            'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' => 'xlsx',
+            'text/plain' => 'txt',
+            'text/csv' => 'csv',
+            'text/html' => 'html',
+            'application/json' => 'json',
+            'application/xml' => 'xml',
+        ];
+
+        return $mimeMap[$type] ?? '';
     }
 
     public function getContentType(string $url): string
@@ -57,7 +69,7 @@ protected function getHeaders(string $url): array
 
         try {
             $response = get_headers($url, 1, $this->streamContext());
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             return [];
         }