Skip to content

Commit 9b7ce34

Browse files
authored
Merge pull request #318 from OpenZWave/bugfix/fix-fragile-build
2 parents 9972406 + 46739fb commit 9b7ce34

File tree

3 files changed

+11
-15
lines changed

3 files changed

+11
-15
lines changed

.travis.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ addons:
99
packages:
1010
- libudev-dev
1111

12-
compiler: clang
13-
1412
before_install:
1513
- wget https://github.com/OpenZWave/open-zwave/archive/master.zip
1614
- unzip master.zip
@@ -20,11 +18,6 @@ before_install:
2018
- npm install -g node-gyp
2119
- cd ..
2220

23-
env:
24-
global:
25-
- CC=/usr/bin/clang
26-
- CXX=/usr/bin/clang++
27-
2821
node_js:
2922
- "0.12"
3023
- "4"

binding.gyp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
"OPENZWAVE_SECURITY=<!@(find <(OZW_INC) -name ZWSecurity.h | wc -l)",
3131
"OPENZWAVE_EXCEPTIONS=<!@(find <(OZW_INC) -name OZWException.h | wc -l)",
3232
"OPENZWAVE_16=<!@(find <(OZW_INC) -name ValueBitSet.h | wc -l)",
33-
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(nm -g --demangle <(OZW_LIB_PATH)libopenzwave.so | grep OpenZWave::Value::GetTypeNameFromEnum | wc -l)",
34-
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(nm -g --demangle <(OZW_LIB_PATH)libopenzwave.so | grep OpenZWave::ValueID::GetTypeAsString | wc -l)"
33+
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(grep -r GetTypeNameFromEnum <(OZW_INC)value_classes | wc -l)",
34+
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(grep -r GetTypeAsString <(OZW_INC)value_classes | wc -l)"
3535
],
3636
"cflags": [
3737
"-Wno-ignored-qualifiers",
@@ -67,8 +67,8 @@
6767
"OPENZWAVE_SECURITY=<!@(find <(OZW_INC) -name ZWSecurity.h | wc -l)",
6868
"OPENZWAVE_EXCEPTIONS=<!@(find <(OZW_INC) -name OZWException.h | wc -l)",
6969
"OPENZWAVE_16=<!@(find <(OZW_INC) -name ValueBitSet.h | wc -l)",
70-
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(symbols <(OZW_LIB_PATH)/libopenzwave.dylib | awk '{print $4}' | grep OpenZWave::Value::GetTypeNameFromEnum | wc -l)",
71-
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(symbols <(OZW_LIB_PATH)/libopenzwave.dylib | awk '{print $4}' | grep OpenZWave::ValueID::GetTypeAsString | wc -l)",
70+
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(grep -r GetTypeNameFromEnum <(OZW_INC)value_classes | wc -l)",
71+
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(grep -r GetTypeAsString <(OZW_INC)value_classes | wc -l)"
7272
],
7373
"link_settings": {
7474
"libraries": [
@@ -102,8 +102,8 @@
102102
"OPENZWAVE_SECURITY=<!@(find <(OZW_INC) -name ZWSecurity.h | wc -l)",
103103
"OPENZWAVE_EXCEPTIONS=<!@(find <(OZW_INC) -name OZWException.h | wc -l)",
104104
"OPENZWAVE_16=<!@(find <(OZW_INC) -name ValueBitSet.h | wc -l)",
105-
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(ldconfig -p | grep 'libopenzwave.so ' | awk '{print $4}' | xargs nm -g --demangle |grep OpenZWave::Value::GetTypeNameFromEnum | wc -l)",
106-
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(ldconfig -p | grep 'libopenzwave.so ' | awk '{print $4}' | xargs nm -g --demangle |grep OpenZWave::ValueID::GetTypeAsString | wc -l)",
105+
"OPENZWAVE_VALUETYPE_FROM_ENUM=<!@(grep -r GetTypeNameFromEnum <(OZW_INC)value_classes | wc -l)",
106+
"OPENZWAVE_VALUETYPE_FROM_VALUEID=<!@(grep -r GetTypeAsString <(OZW_INC)value_classes | wc -l)"
107107
],
108108
"link_settings": {
109109
"libraries": ["-lopenzwave"]
@@ -119,6 +119,9 @@
119119
"-Wno-unknown-pragmas",
120120
"<!@(find <(OZW_INC) -name OZWException.h -exec echo -n \"-fexceptions\" \\;)"
121121
],
122+
"cflags_cc": [
123+
"-std=c++11"
124+
],
122125
"cflags_cc!": [
123126
"<!@(find <(OZW_INC) -name OZWException.h -exec echo -n \"-fno-exceptions\" \\;)"
124127
]

src/utils.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,8 @@ namespace OZW {
275275
AddStringProp (nodeobj, type, value.GetTypeAsString());
276276
AddStringProp (nodeobj, genre, value.GetGenreAsString());
277277
#elif OPENZWAVE_VALUETYPE_FROM_ENUM
278-
AddStringProp (nodeobj, type, OpenZWave::Value::GetTypeNameFromEnum(value.GetType()));
279-
AddStringProp (nodeobj, genre, OpenZWave::Value::GetGenreNameFromEnum(value.GetGenre()));
278+
AddStringProp (nodeobj, type, OpenZWave::Internal::VC::ValueList::GetTypeNameFromEnum(value.GetType()));
279+
AddStringProp (nodeobj, genre, OpenZWave::Internal::VC::ValueList::GetGenreNameFromEnum(value.GetGenre()));
280280
#else
281281
AddIntegerProp(nodeobj, type, value.GetType());
282282
AddIntegerProp(nodeobj, genre, value.GetGenre());

0 commit comments

Comments
 (0)