ref: make all start fns accept immutable self

Author: 0xNeshi

src/block_range_scanner/scanner.rs

@@ -132,7 +132,7 @@ impl<N: Network> BlockRangeScanner<N> {
     /// * [`ScannerError::Timeout`] - if an RPC call required for startup times out.
     /// * [`ScannerError::RpcError`] - if an RPC call required for startup fails.
     pub async fn stream_live(
-        &mut self,
+        &self,
         block_confirmations: u64,
     ) -> Result<ReceiverStream<BlockScannerResult>, ScannerError> {
         info!("Starting live stream");
@@ -185,7 +185,7 @@ impl<N: Network> BlockRangeScanner<N> {
     /// * [`ScannerError::RpcError`] - if an RPC call required for startup fails.
     /// * [`ScannerError::BlockNotFound`] - if `start_id` or `end_id` cannot be resolved.
     pub async fn stream_historical(
-        &mut self,
+        &self,
         start_id: impl Into<BlockId>,
         end_id: impl Into<BlockId>,
     ) -> Result<ReceiverStream<BlockScannerResult>, ScannerError> {

src/event_scanner/scanner/historic.rs

@@ -133,7 +133,7 @@ impl<N: Network> EventScanner<Historic, N> {
     /// * [`ScannerError::Timeout`] - if an RPC call required for startup times out.
     /// * [`ScannerError::RpcError`] - if an RPC call required for startup fails.
     /// * [`ScannerError::BlockNotFound`] - if `from_block` or `to_block` cannot be resolved.
-    pub async fn start(mut self) -> Result<(), ScannerError> {
+    pub async fn start(self) -> Result<(), ScannerError> {
         let stream = self
             .block_range_scanner
             .stream_historical(self.config.from_block, self.config.to_block)

src/event_scanner/scanner/live.rs

@@ -67,7 +67,7 @@ impl<N: Network> EventScanner<Live, N> {
     ///
     /// * [`ScannerError::Timeout`] - if an RPC call required for startup times out.
     /// * [`ScannerError::RpcError`] - if an RPC call required for startup fails.
-    pub async fn start(mut self) -> Result<(), ScannerError> {
+    pub async fn start(self) -> Result<(), ScannerError> {
         let stream = self.block_range_scanner.stream_live(self.config.block_confirmations).await?;
         let max_concurrent_fetches = self.config.max_concurrent_fetches;
         let provider = self.block_range_scanner.provider().clone();