Skip to content

Commit 949c617

Browse files
authored
Address feedback for Account (#523)
1 parent 0a650c9 commit 949c617

File tree

5 files changed

+559
-17
lines changed

5 files changed

+559
-17
lines changed

packages/core/solidity/src/account.test.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ test('account API assert defaults', async t => {
5050
t.is(account.print(account.defaults), account.print());
5151
});
5252

53-
for (const signer of [undefined, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
53+
for (const signer of [false, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
5454
let title = 'Account';
5555
if (signer) {
5656
title += ` with Signer${signer}`;
@@ -102,6 +102,18 @@ for (const signer of [undefined, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
102102
ERC7579Modules: 'AccountERC7579',
103103
});
104104

105+
testAccount(`${title} with ERC7579 with ERC1271`, {
106+
signer,
107+
ERC7579Modules: 'AccountERC7579',
108+
signatureValidation: 'ERC1271',
109+
});
110+
111+
testAccount(`${title} with ERC7579 with ERC7739`, {
112+
signer,
113+
ERC7579Modules: 'AccountERC7579',
114+
signatureValidation: 'ERC7739',
115+
});
116+
105117
testAccount(`${title} with ERC7579 hooks`, {
106118
signer,
107119
ERC7579Modules: 'AccountERC7579Hooked',

0 commit comments

Comments
 (0)