Flatten AxelarGatewayAdapter contract #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
requested changes
Aug 15, 2025
Open
frangio
changed the title
Amxx
commented
Aug 18, 2025
| * The contract implements AxelarExecutable's {_execute} function to execute the message, converting Axelar's native | ||
| * workflow into the standard ERC-7786. | ||
| */ | ||
| // slither-disable-next-line locked-ether |
There was a problem hiding this comment.
Note: sendMessage is maked as payable, so slither believes this contract can lock ether. Slither is missing the fact that sendMessage does require(msg.value == 0, UnsupportedNativeTransfer());. IERC7786GatewaySource asks that sendMessage is payable, so we have to disable slither here.
frangio
previously approved these changes
Aug 19, 2025
| (bytes2 chainType, bytes calldata chainReference, ) = recipient.parseV1Calldata(); | ||
| bytes memory remoteGateway = getRemoteGateway(chainType, chainReference); | ||
| string memory axelarDestination = getAxelarChain(InteroperableAddress.formatV1(chainType, chainReference, "")); | ||
| string memory axelarTarget = address(bytes20(remoteGateway)).toChecksumHexString(); // TODO non-evm chains? |
There was a problem hiding this comment.
Let's remove all "TODO" comments. If the contract doesn't support non-EVM chains, let's document that in the contract-level documentation.
luiz-lvj
approved these changes
Aug 20, 2025
| ) Ownable(initialOwner) AxelarExecutable(address(gateway)) {} | ||
|
|
||
| /// @dev Returns the Axelar chain identifier for a given binary interoperable chain id. | ||
| function getAxelarChain(bytes memory input) public view virtual returns (string memory output) { |
There was a problem hiding this comment.
Maybe getAxelarChainIdentifier or getAxelarChainId would be clearer?
| } | ||
|
|
||
| /// @dev Registers a chain equivalence between a binary interoperable chain id and an Axelar chain identifier. | ||
| function registerChainEquivalence(bytes calldata chain, string calldata axelar) public virtual onlyOwner { |
There was a problem hiding this comment.
Would be more expressive imo
Suggested change
| function registerChainEquivalence(bytes calldata chain, string calldata axelar) public virtual onlyOwner { | |
| function registerChainEquivalence(bytes calldata chain, string calldata axelarId) public virtual onlyOwner { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
Based on #200