Skip to content

Commit a21e52d

Browse files
Transpile 325cd77cc
1 parent 975480d commit a21e52d

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

contracts/utils/cryptography/signers/MultiSignerERC7913Upgradeable.sol

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ abstract contract MultiSignerERC7913Upgradeable is Initializable, AbstractSigner
8080
/// @dev The `signer` is less than 20 bytes long.
8181
error MultiSignerERC7913InvalidSigner(bytes signer);
8282

83+
/// @dev The `threshold` is zero.
84+
error MultiSignerERC7913ZeroThreshold();
85+
8386
/// @dev The `threshold` is unreachable given the number of `signers`.
8487
error MultiSignerERC7913UnreachableThreshold(uint64 signers, uint64 threshold);
8588

@@ -171,6 +174,7 @@ abstract contract MultiSignerERC7913Upgradeable is Initializable, AbstractSigner
171174
*/
172175
function _setThreshold(uint64 newThreshold) internal virtual {
173176
MultiSignerERC7913Storage storage $ = _getMultiSignerERC7913Storage();
177+
require(newThreshold > 0, MultiSignerERC7913ZeroThreshold());
174178
$._threshold = newThreshold;
175179
_validateReachableThreshold();
176180
emit ERC7913ThresholdSet(newThreshold);

scripts/upgradeable/transpile-onto.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ if [[ -v SUBMODULE_REMOTE ]]; then
4848
git add "$lib"
4949
fi
5050

51-
git commit -m "Transpile $commit"
51+
git commit -m "Transpile $commit" --no-verify
5252

5353
# return to original branch
5454
git checkout "$start_branch"

test/account/AccountMultiSigner.test.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,14 @@ describe('AccountMultiSigner', function () {
176176
await expect(this.mock.$_setThreshold(2)).to.emit(this.mock, 'ERC7913ThresholdSet');
177177

178178
// Unreachable threshold reverts
179-
await expect(this.mock.$_setThreshold(3)).to.revertedWithCustomError(
179+
await expect(this.mock.$_setThreshold(3))
180+
.to.revertedWithCustomError(this.mock, 'MultiSignerERC7913UnreachableThreshold')
181+
.withArgs(2, 3);
182+
183+
// Zero threshold reverts
184+
await expect(this.mock.$_setThreshold(0)).to.revertedWithCustomError(
180185
this.mock,
181-
'MultiSignerERC7913UnreachableThreshold',
186+
'MultiSignerERC7913ZeroThreshold',
182187
);
183188
});
184189

0 commit comments

Comments
 (0)