Skip to content

Commit 06ea3b1

Browse files
ernestognwarr00
andauthored
Add Slither reentrancy exception to GovernorTimelockAccess._queueOperations (#5643)
Co-authored-by: Arr00 <[email protected]>
1 parent 21c8312 commit 06ea3b1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

contracts/governance/extensions/GovernorTimelockAccess.sol

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,9 @@ abstract contract GovernorTimelockAccess is Governor {
237237
for (uint256 i = 0; i < targets.length; ++i) {
238238
(, bool withDelay, ) = _getManagerData(plan, i);
239239
if (withDelay) {
240+
// This function can reenter when calling `_manager.schedule` before performing state updates in `_setManagerData`.
241+
// However, the `manager` is a trusted contract in the current context's security model (e.g. an `AccessManager`).
242+
// slither-disable-next-line reentrancy-no-eth
240243
(, uint32 nonce) = _manager.schedule(targets[i], calldatas[i], etaSeconds);
241244
_setManagerData(plan, i, true, nonce);
242245
}

0 commit comments

Comments
 (0)