Remove redundant getVotes call in Governor (#4940)

aman7100 · Amxx · ernestognw · web-flow · commit 7417c5946f8a · 2024-03-04T18:34:05.000+01:00
Co-authored-by: Hadrien Croubois &lt;hadrien.croubois@gmail.com&gt;
Co-authored-by: ernestognw &lt;ernestognw@gmail.com&gt;
diff --git a/contracts/governance/Governor.sol b/contracts/governance/Governor.sol
@@ -286,10 +286,12 @@ abstract contract Governor is Context, ERC165, EIP712, Nonces, IGovernor, IERC72
         }
 
         // check proposal threshold
-        uint256 proposerVotes = getVotes(proposer, clock() - 1);
         uint256 votesThreshold = proposalThreshold();
-        if (proposerVotes < votesThreshold) {
-            revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);
+        if (votesThreshold > 0) {
+            uint256 proposerVotes = getVotes(proposer, clock() - 1);
+            if (proposerVotes < votesThreshold) {
+                revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);
+            }
         }
 
         return _propose(targets, values, calldatas, description, proposer);

Original file line number	Diff line number	Diff line change
`@@ -286,10 +286,12 @@ abstract contract Governor is Context, ERC165, EIP712, Nonces, IGovernor, IERC72`
`286`	`286`	`}`
`287`	`287`
`288`	`288`	`// check proposal threshold`
`289`		`- uint256 proposerVotes = getVotes(proposer, clock() - 1);`
`290`	`289`	`uint256 votesThreshold = proposalThreshold();`
`291`		`- if (proposerVotes < votesThreshold) {`
`292`		`- revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);`
	`290`	`+ if (votesThreshold > 0) {`
	`291`	`+ uint256 proposerVotes = getVotes(proposer, clock() - 1);`
	`292`	`+ if (proposerVotes < votesThreshold) {`
	`293`	`+ revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);`
	`294`	`+ }`
`293`	`295`	`}`
`294`	`296`
`295`	`297`	`return _propose(targets, values, calldatas, description, proposer);`