Use free memory pointer for returndatacopy (#5057)

frangio · web-flow · commit a241f0990549 · 2024-05-27T21:29:07.000+02:00
diff --git a/contracts/utils/Create2.sol b/contracts/utils/Create2.sol
@@ -46,8 +46,9 @@ library Create2 {
             addr := create2(amount, add(bytecode, 0x20), mload(bytecode), salt)
             // if no address was created, and returndata is not empty, bubble revert
             if and(iszero(addr), not(iszero(returndatasize()))) {
-                returndatacopy(0, 0, returndatasize())
-                revert(0, returndatasize())
+                let p := mload(0x40)
+                returndatacopy(p, 0, returndatasize())
+                revert(p, returndatasize())
             }
         }
         if (addr == address(0)) {

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,9 @@ library Create2 {`
`46`	`46`	`addr := create2(amount, add(bytecode, 0x20), mload(bytecode), salt)`
`47`	`47`	`// if no address was created, and returndata is not empty, bubble revert`
`48`	`48`	`if and(iszero(addr), not(iszero(returndatasize()))) {`
`49`		`- returndatacopy(0, 0, returndatasize())`
`50`		`- revert(0, returndatasize())`
	`49`	`+ let p := mload(0x40)`
	`50`	`+ returndatacopy(p, 0, returndatasize())`
	`51`	`+ revert(p, returndatasize())`
`51`	`52`	`}`
`52`	`53`	`}`
`53`	`54`	`if (addr == address(0)) {`