Update index.js

Amxx · web-flow · commit ba351f3211ed · 2025-07-10T23:41:44.000+02:00
diff --git a/scripts/solhint-custom/index.js b/scripts/solhint-custom/index.js
@@ -74,8 +74,11 @@ module.exports = [
       if (node.visibility === 'internal' && node.parent.kind === 'library' && /^_/.test(node.name)) {
         this.error(node, 'Library internal functions should not have leading underscore');
       }
-      if (node.visibility === 'public' || node.visibility === 'external' && /^_/.test(node.name)) {
-        this.error(node, 'Public and external functions should not have leading underscore');
+      if (node.visibility === 'public' && /^_/.test(node.name)) {
+        this.error(node, 'Public functions should not have leading underscore');
+      }
+      if (node.visibility === 'external' && /^_/.test(node.name)) {
+        this.error(node, 'External functions should not have leading underscore');
       }
     }
   },

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,11 @@ module.exports = [`
`74`	`74`	`if (node.visibility === 'internal' && node.parent.kind === 'library' && /^_/.test(node.name)) {`
`75`	`75`	`this.error(node, 'Library internal functions should not have leading underscore');`
`76`	`76`	`}`
`77`		`- if (node.visibility === 'public' \|\| node.visibility === 'external' && /^_/.test(node.name)) {`
`78`		`- this.error(node, 'Public and external functions should not have leading underscore');`
	`77`	`+ if (node.visibility === 'public' && /^_/.test(node.name)) {`
	`78`	`+ this.error(node, 'Public functions should not have leading underscore');`
	`79`	`+ }`
	`80`	`+ if (node.visibility === 'external' && /^_/.test(node.name)) {`
	`81`	`+ this.error(node, 'External functions should not have leading underscore');`
`79`	`82`	`}`
`80`	`83`	`}`
`81`	`84`	`},`