Base64.decode #5765
Open
Base64.decode #5765
+172
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a43352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amxx
commented
Jun 23, 2025
arr00
reviewed
Aug 21, 2025
Co-authored-by: Arr00 <[email protected]>
…eppelin-contracts into feature/base64-decode
arr00
previously approved these changes
Aug 22, 2025
Change error param to `bytes1`
arr00
approved these changes
Aug 22, 2025
|
For the record, this is how the lookup table are computed: https://gist.github.com/Amxx/ae43dc9dc24427f364c9d5789ad65896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4287
Note: this uses a different decoding table than solady. It might not be as efficient, but its a method I 100% understand and can explain. The solady method feels like magic to me ... but maybe its magic we want.
Note that changing the decoding method can always be done at a later stage. It should be backward compatible anyway
PR Checklist
npx changeset add)