Skip to content

[Feature]: Remove ERC721ReceiverMock Solidity contract from erc721 e2e tests #745

@0xNeshi

Description

@0xNeshi

What is the feature you would like to see?

The contract in question is examples/erc721/tests/mock/receiver.rs > ERC721ReceiverMock.

Since PR #729, it is possible to deploy custom Stylus contracts in e2e. We can use this to replace this mock Solidity contract with a new Erc721Holder example contract in the ./examples/ directory.

This achieves a couple of things:

  1. Mock contract is now written in Stylus and used in e2e, further increasing contract library reliability.
  2. Users get to see an example Erc721Holder implementation.

A single e2e test would be sufficient to verify that the contract example is deployable.

TODO:

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines

Metadata

Metadata

Assignees

Labels

effort: lowEasy or tiny task that takes less than a day.type: testChanges to the testing suite.

Projects

Status

In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions