-
Notifications
You must be signed in to change notification settings - Fork 69
Open
Copy link
Labels
effort: lowEasy or tiny task that takes less than a day.Easy or tiny task that takes less than a day.type: testChanges to the testing suite.Changes to the testing suite.
Milestone
Description
What is the feature you would like to see?
The contract in question is examples/erc721/tests/mock/receiver.rs > ERC721ReceiverMock.
Since PR #729, it is possible to deploy custom Stylus contracts in e2e. We can use this to replace this mock Solidity contract with a new Erc721Holder
example contract in the ./examples/ directory.
This achieves a couple of things:
- Mock contract is now written in Stylus and used in e2e, further increasing contract library reliability.
- Users get to see an example
Erc721Holder
implementation.
A single e2e test would be sufficient to verify that the contract example is deployable.
TODO:
- Implement examples/erc721-holder/
- Implement at least a single e2e test verifying the contract can be deployed and that it returns the expected RECEIVER_FN_SELECTOR value.
- Replace ERC721ReceiverMock Solidity contract usage in erc721 e2e tests (to see how another example can be deployed in e2e tests, see example/beacon-proxy)
- Remove ERC721ReceiverMock.
Contribution Guidelines
- I agree to follow this project's Contribution Guidelines
Metadata
Metadata
Assignees
Labels
effort: lowEasy or tiny task that takes less than a day.Easy or tiny task that takes less than a day.type: testChanges to the testing suite.Changes to the testing suite.
Type
Projects
Status
In Progress