refactor: simplify bounds check with .some()

Tarquinen · Tarquinen · commit 551f0d88aa1e · 2025-12-15T11:19:58.000-05:00
diff --git a/lib/strategies/prune-tool.ts b/lib/strategies/prune-tool.ts
@@ -72,8 +72,7 @@ export function createPruneTool(
             const toolIdList: string[] = buildToolIdList(messages)
 
             // Validate that all numeric IDs are within bounds
-            const invalidIds = numericToolIds.filter(id => id < 0 || id >= toolIdList.length)
-            if (invalidIds.length > 0) {
+            if (numericToolIds.some(id => id < 0 || id >= toolIdList.length)) {
                 return "Invalid IDs provided. Only use numeric IDs from the <prunable-tools> list."
             }
 

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,7 @@ export function createPruneTool(`
`72`	`72`	`const toolIdList: string[] = buildToolIdList(messages)`
`73`	`73`
`74`	`74`	`// Validate that all numeric IDs are within bounds`
`75`		`- const invalidIds = numericToolIds.filter(id => id < 0 \|\| id >= toolIdList.length)`
`76`		`- if (invalidIds.length > 0) {`
	`75`	`+ if (numericToolIds.some(id => id < 0 \|\| id >= toolIdList.length)) {`
`77`	`76`	`return "Invalid IDs provided. Only use numeric IDs from the <prunable-tools> list."`
`78`	`77`	`}`
`79`	`78`