Fix version detection to work from any execution path #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getLocalVersion() function now walks up the directory tree to find the correct package.json instead of assuming a fixed relative path. This fixes version detection when running from dist/lib/, lib/, or when installed in node_modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getLocalVersion()to walk up directory tree instead of assuming a fixed relative path (../../package.json)dist/lib/,lib/, or when installed innode_modulesDetails
The version checker previously assumed the package.json was always at
../../package.jsonrelative to the module. This broke when the module executed from different locations. The new implementation walks up to 5 directory levels looking for a package.json with the correct package name (@tarquinen/opencode-dcp).