fix: typecheck

Author: lindesvard

apps/api/src/controllers/insights.controller.ts

@@ -96,8 +96,6 @@ export async function getPages(
     startDate: startDate,
     endDate: endDate,
     timezone,
-    cursor: parsed.data.cursor,
-    limit: Math.min(parsed.data.limit, 50),
   });
 }
 
@@ -170,8 +168,6 @@ export function getOverviewGeneric(
         startDate: startDate,
         endDate: endDate,
         timezone,
-        cursor: parsed.data.cursor,
-        limit: Math.min(parsed.data.limit, 50),
       }),
     );
   };

package.json

@@ -25,7 +25,7 @@
     "lint": "biome check .",
     "lint:fix": "biome check --write .",
     "lint:workspace": "pnpm dlx sherif@latest",
-    "typecheck": "pnpm -r typecheck",
+    "typecheck": "pnpm -r --no-bail typecheck",
     "update-simple-git-hooks": "npx simple-git-hooks"
   },
   "simple-git-hooks": {

packages/db/src/engine/index.ts

@@ -127,6 +127,8 @@ export async function executeAggregateChart(
       endDate: normalized.endDate,
       breakdowns: normalized.breakdowns,
       limit: normalized.limit,
+      metric: normalized.metric,
+      previous: normalized.previous,
       timezone,
     };
 
@@ -251,6 +253,8 @@ export async function executeAggregateChart(
         endDate: previousPeriod.endDate,
         breakdowns: normalized.breakdowns,
         limit: normalized.limit,
+        metric: normalized.metric,
+        previous: normalized.previous,
         timezone,
       };
 

packages/db/src/services/chart.service.ts

@@ -1,4 +1,3 @@
-import { uniq } from 'ramda';
 import sqlstring from 'sqlstring';
 
 import { DateTime, stripLeadingAndTrailingSlashes } from '@openpanel/common';
@@ -355,23 +354,10 @@ export function getAggregateChartSql({
   endDate,
   projectId,
   limit,
-  timezone,
 }: Omit<IGetChartDataInput, 'interval' | 'chartType'> & {
   timezone: string;
 }) {
-  const {
-    sb,
-    join,
-    getWhere,
-    getFrom,
-    getJoins,
-    getSelect,
-    getOrderBy,
-    getGroupBy,
-    getWith,
-    with: addCte,
-    getSql,
-  } = createSqlBuilder();
+  const { sb, join, getJoins, with: addCte, getSql } = createSqlBuilder();
 
   sb.where = getEventFiltersWhereClause(event.filters);
   sb.where.projectId = `project_id = ${sqlstring.escape(projectId)}`;

packages/db/src/services/pages.service.ts

@@ -1,7 +1,7 @@
 import { TABLE_NAMES, ch } from '../clickhouse/client';
 import { clix } from '../clickhouse/query-builder';
 
-export interface IGetTopPagesInput {
+export interface IGetPagesInput {
   projectId: string;
   startDate: string;
   endDate: string;
@@ -28,7 +28,7 @@ export class PagesService {
     endDate,
     timezone,
     search,
-  }: IGetTopPagesInput): Promise<ITopPage[]> {
+  }: IGetPagesInput): Promise<ITopPage[]> {
     // CTE: Get titles from the last 30 days for faster retrieval
     const titlesCte = clix(this.client, timezone)
       .select([