hatch-dependency-coversion: handle optional deps (#13)

They're in a different part of the metadata.

Author: sfoster1

hatch-dependency-coversion/changelog.d/3-handle-optional-dependencies.md

@@ -0,0 +1,4 @@
+# Handle optional dependencies
+
+Also update any optional dependencies if they're present in the plugin config.
+

hatch-dependency-coversion/src/hatch_dependency_coversion/metadata_hook.py

@@ -39,6 +39,21 @@ def _update_dependency_versions(
             for depspec in dependencies_metadata
         ]
 
+    def _update_optional_dependency_versions(
+        self,
+        optional_dependencies_metadata: dict[str, list[str]],
+        version: str,
+        which_dependencies: list[str],
+    ) -> dict[str, list[str]]:
+        """Do the actual optional dependency update"""
+        return {
+            extra: [
+                self._maybe_update_dep(depspec, version, which_dependencies)
+                for depspec in optional_dep_list
+            ]
+            for extra, optional_dep_list in optional_dependencies_metadata.items()
+        }
+
     def update(self, metadata: dict[str, Any]) -> None:
         """Update metadata for coversioning."""
         # this is from https://github.com/flying-sheep/hatch-docstring-description/blob/main/src/hatch_docstring_description/read_description.py
@@ -54,9 +69,18 @@ def update(self, metadata: dict[str, Any]) -> None:
                 "tool.hatch.metadata.hooks.dependency-coversion.override-versions-of must be an array of strings"
             )
         override_of: list[str] = self.config["override-versions-of"]
-        metadata["dependencies"] = self._update_dependency_versions(
-            metadata.get("dependencies", []), metadata["version"], override_of
-        )
+        if "dependencies" in metadata:
+            metadata["dependencies"] = self._update_dependency_versions(
+                metadata.get("dependencies", []), metadata["version"], override_of
+            )
+        if "optional-dependencies" in metadata:
+            metadata[
+                "optional-dependencies"
+            ] = self._update_optional_dependency_versions(
+                metadata.get("optional-dependencies", {}),
+                metadata["version"],
+                override_of,
+            )
 
     def get_known_classifiers(self) -> list[str]:
         """Dummy function that is part of the hook interface."""

hatch-dependency-coversion/tests/conftest.py

@@ -160,3 +160,32 @@ def requests_multiple_project(tmp_path: Path, static_requirements: list[str]) ->
     (tmp_path / "coversion_of_multiple_project").mkdir()
     (tmp_path / "coversion_of_multiple_project" / "__init__.py").write_text("")
     return tmp_path
+
+
+@pytest.fixture
+def requests_coversion_of_optional_dependency_project(
+    tmp_path: Path, static_requirements: list[str]
+) -> Path:
+    (tmp_path / "pyproject.toml").write_text(
+        dedent(
+            f"""
+        [build-system]
+        requires = ["hatchling", "hatch-dependency-coversion"]
+        build-backend = "hatchling.build"
+        [project]
+        name = "coversion-of-optional-dependency-project"
+        version = "0.1.0"
+        dependencies = [{','.join([f'"{requirement}"' for requirement in static_requirements[1:]])}]
+        dynamic = ['dependency-coversion']
+        [project.optional-dependencies]
+        extra1 = [{f'"{static_requirements[0]}"'}]
+        [tool.hatch.metadata.hooks.dependency-coversion]
+        override-versions-of=["dependency1"]
+            """
+        )
+    )
+    (tmp_path / "coversion_of_optional_dependency_project").mkdir()
+    (tmp_path / "coversion_of_optional_dependency_project" / "__init__.py").write_text(
+        ""
+    )
+    return tmp_path

hatch-dependency-coversion/tests/test_metadata_hook.py

@@ -53,3 +53,16 @@ def test_coversion_of_marked_version_applies(
     assert sorted(requires) == static_requirements[:2] + [
         "dependency3==0.1.0; os_name == 'Windows'"
     ]
+
+
+def test_coversion_of_optional_dependency_applies(
+    requests_coversion_of_optional_dependency_project: Path,
+    static_requirements: list[str],
+) -> None:
+    wheelpath = build_wheel(requests_coversion_of_optional_dependency_project)
+    dist_metadata = pkginfo.Wheel(str(wheelpath))
+    requires = dist_metadata.requires_dist
+    assert (
+        sorted(requires)
+        == ["dependency1==0.1.0; extra == 'extra1'"] + static_requirements[1:]
+    )