Skip to content

Commit a16a131

Browse files
authored
Fix pull-request-target changelog requirements (#7)
I implemented a workflow to check whether a pull request had a news fragment but I did it with `pull_request_target`, which doesn't have access to the code from the PR. It's really just for doing surface level checks of PRs that you can always trust to run. Make it a normal `pull_request` trigger.
1 parent 1c481c7 commit a16a131

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/pull-request-target.yml renamed to .github/workflows/pull-request-checking.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: 'pull request checking'
22
on:
3-
pull_request_target:
3+
pull_request:
44
types:
55
- opened
66
- synchronize
@@ -24,9 +24,9 @@ jobs:
2424
run: |
2525
echo "HATCH_VCS_TUNABLE_DIFF=\"${GIT_DIFF_FILTERED}\"" >> $GITHUB_OUTPUT
2626
hatch-vcs-tunable-analysis:
27+
if: ${{ contains(needs.which-paths.outputs.HATCH_VCS_TUNABLE_DIFF, 'hatch_vcs_tunable')}}
2728
runs-on: ubuntu-latest
2829
needs: [which-paths]
29-
if: ${{ needs.which-paths.outputs.HATCH_VCS_TUNABLE_DIFF }}
3030
steps:
3131
- name: Ask for news fragments
3232
if: ${{ !contains(needs.which-paths.outputs.HATCH_VCS_TUNABLE_DIFF, 'changelog.d') }}

0 commit comments

Comments
 (0)