fix(protocol-designer): create_deck_fixture step form reducer to prop… (#18539)

…erly populate trash

closes RQA-4249

Author: jerader

protocol-designer/src/step-forms/reducers/index.ts

@@ -377,39 +377,33 @@ export const savedStepForms = (
       const prevInitialDeckSetupStep =
         savedStepForms[INITIAL_DECK_SETUP_STEP_ID]
       const locationUpdate = `${name}LocationUpdate`
-      return mapValues(
-        savedStepForms,
-        (form: FormData): FormData => {
-          if (form.stepType === 'manualIntervention') {
-            return {
-              ...form,
-              [INITIAL_DECK_SETUP_STEP_ID]: {
-                ...prevInitialDeckSetupStep,
-                [locationUpdate]: {
-                  ...prevInitialDeckSetupStep[locationUpdate],
-                  [id]: location,
-                },
+      return mapValues(savedStepForms, (savedForm: FormData, formId) => {
+        if (formId === INITIAL_DECK_SETUP_STEP_ID) {
+          return {
+            ...prevInitialDeckSetupStep,
+            [locationUpdate]: {
+              ...prevInitialDeckSetupStep[locationUpdate],
+              [id]: location,
+            },
+          }
+        } else if (
+          savedForm.dropTip_location == null &&
+          (name === 'trashBin' || name === 'wasteChute')
+        ) {
+          return {
+            ...savedForm,
+            ...handleFormChange(
+              {
+                dropTip_location: id,
               },
-            }
-          } else if (
-            form.dropTip_location == null &&
-            (name === 'trashBin' || name === 'wasteChute')
-          ) {
-            return {
-              ...form,
-              ...handleFormChange(
-                {
-                  dropTip_location: id,
-                },
-                form,
-                _getPipetteEntitiesRootState(rootState),
-                _getLabwareEntitiesRootState(rootState)
-              ),
-            }
+              savedForm,
+              _getPipetteEntitiesRootState(rootState),
+              _getLabwareEntitiesRootState(rootState)
+            ),
           }
-          return form
         }
-      )
+        return savedForm
+      })
     }
     case 'DELETE_DECK_FIXTURE': {
       const { id } = action.payload