refactor(app): Improve RunModuleInfo typing (#19175)

Author: SyntaxColoring

app/src/organisms/ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx

@@ -131,18 +131,16 @@ export function TwoColLwInfoAndDeck(
         const isValidDeck =
           currentLoc != null && newLoc != null && movedLabwareDef != null
 
-        const modulesOnDeck = moduleRenderInfo
-          ?.filter(module => module.targetSlotId != null)
-          .map(module => {
-            return {
-              moduleModel: module.moduleDef.model,
-              moduleLocation: { slotName: module.targetSlotId ?? '' },
-              nestedLabwareDef:
-                module.nestedLabwareId !== failedLwId
-                  ? module.nestedLabwareDef
-                  : null,
-            }
-          })
+        const modulesOnDeck = moduleRenderInfo?.map(module => {
+          return {
+            moduleModel: module.moduleDef.model,
+            moduleLocation: { slotName: module.targetSlotId },
+            nestedLabwareDef:
+              module.nestedLabwareId !== failedLwId
+                ? module.nestedLabwareDef
+                : null,
+          }
+        })
         return isValidDeck ? (
           <MoveLabwareOnDeck
             deckFill={isOnDevice ? COLORS.grey35 : '#e6e6e6'}

app/src/organisms/InterventionModal/MoveLabwareInterventionContent.tsx

@@ -132,18 +132,16 @@ export function MoveLabwareInterventionContent({
     deckDef,
     labwareDefsByUri
   )
-  const modulesOnDeck = moduleRenderInfo
-    ?.filter(module => module.targetSlotId != null)
-    .map(module => {
-      return {
-        moduleModel: module.moduleDef.model,
-        moduleLocation: { slotName: module.targetSlotId ?? '' },
-        nestedLabwareDef:
-          module.nestedLabwareId !== command.params.labwareId
-            ? module.nestedLabwareDef
-            : null,
-      }
-    })
+  const modulesOnDeck = moduleRenderInfo?.map(module => {
+    return {
+      moduleModel: module.moduleDef.model,
+      moduleLocation: { slotName: module.targetSlotId },
+      nestedLabwareDef:
+        module.nestedLabwareId !== command.params.labwareId
+          ? module.nestedLabwareDef
+          : null,
+    }
+  })
 
   const oldLabwareLocation =
     getLoadedLabware(run.labware, command.params.labwareId)?.location ?? null

app/src/organisms/InterventionModal/utils/getRunModuleRenderInfo.ts

@@ -21,8 +21,8 @@ export interface RunModuleInfo {
   moduleDef: ModuleDefinition
   nestedLabwareDef: LabwareDefinition | null
   nestedLabwareId: string | null
-  targetDeckId: ComponentProps<typeof Module>['targetDeckId']
-  targetSlotId: ComponentProps<typeof Module>['targetSlotId']
+  targetDeckId: NonNullable<ComponentProps<typeof Module>['targetDeckId']>
+  targetSlotId: NonNullable<ComponentProps<typeof Module>['targetSlotId']>
 }
 
 export function getRunModuleRenderInfo(