fix(protocol-designer): auto-populate the drop tip location if applicable (#18500)

closes RQA-4239

Author: jerader

protocol-designer/src/step-forms/reducers/index.ts

@@ -377,16 +377,39 @@ export const savedStepForms = (
       const prevInitialDeckSetupStep =
         savedStepForms[INITIAL_DECK_SETUP_STEP_ID]
       const locationUpdate = `${name}LocationUpdate`
-      return {
-        ...savedStepForms,
-        [INITIAL_DECK_SETUP_STEP_ID]: {
-          ...prevInitialDeckSetupStep,
-          [locationUpdate]: {
-            ...prevInitialDeckSetupStep[locationUpdate],
-            [id]: location,
-          },
-        },
-      }
+      return mapValues(
+        savedStepForms,
+        (form: FormData): FormData => {
+          if (form.stepType === 'manualIntervention') {
+            return {
+              ...form,
+              [INITIAL_DECK_SETUP_STEP_ID]: {
+                ...prevInitialDeckSetupStep,
+                [locationUpdate]: {
+                  ...prevInitialDeckSetupStep[locationUpdate],
+                  [id]: location,
+                },
+              },
+            }
+          } else if (
+            form.dropTip_location == null &&
+            (name === 'trashBin' || name === 'wasteChute')
+          ) {
+            return {
+              ...form,
+              ...handleFormChange(
+                {
+                  dropTip_location: id,
+                },
+                form,
+                _getPipetteEntitiesRootState(rootState),
+                _getLabwareEntitiesRootState(rootState)
+              ),
+            }
+          }
+          return form
+        }
+      )
     }
     case 'DELETE_DECK_FIXTURE': {
       const { id } = action.payload
@@ -396,13 +419,41 @@ export const savedStepForms = (
       return mapValues(
         savedStepForms,
         (form: FormData): FormData => {
-          const updatedLocation = omit(form[locationUpdate] || {}, id)
+          if (form.stepType === 'manualIntervention') {
+            const updatedLocation = omit(form[locationUpdate] || {}, id)
 
-          return {
-            ...form,
-            [locationUpdate]:
-              Object.keys(updatedLocation).length > 0 ? updatedLocation : {},
+            return {
+              ...form,
+              [locationUpdate]:
+                Object.keys(updatedLocation).length > 0 ? updatedLocation : {},
+            }
+          } else if (id.includes(form.dropTip_location as string)) {
+            return {
+              ...form,
+              ...handleFormChange(
+                {
+                  dropTip_location: null,
+                },
+                form,
+                _getPipetteEntitiesRootState(rootState),
+                _getLabwareEntitiesRootState(rootState)
+              ),
+            }
+          } else if (id.includes(form.newLocation as string)) {
+            return {
+              ...form,
+              ...handleFormChange(
+                {
+                  newLocation: null,
+                },
+                form,
+                _getPipetteEntitiesRootState(rootState),
+                _getLabwareEntitiesRootState(rootState)
+              ),
+            }
           }
+
+          return form
         }
       )
     }
@@ -668,7 +719,6 @@ export const savedStepForms = (
         return { ...savedForm, ...deleteLabwareUpdate }
       })
     }
-
     case 'DELETE_PIPETTES': {
       // remove references to pipettes that have been deleted
       const deletedPipetteIds = action.payload