fix(protocol-designer): fix wastechute and trashbin check for dispense (#19709)

koji · web-flow · commit 35ad5277a83e · 2025-10-02T11:40:09.000-04:00
* fix(protocol-designer): fix wastechute and trashbin check for dispense
diff --git a/protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx b/protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx
@@ -171,8 +171,9 @@ export const SecondStepsMoveLiquidTools = ({
     ]
   )
   const labwareId = formData[`${tab}_labware`]
+  const shouldCheckLabwareDef = tab === 'aspirate' || !isDestinationTrash
   // The getMinXYDimension() call below is crashing quite often, but I'm not sure why
-  if (!labwareEntities[labwareId]?.def) {
+  if (shouldCheckLabwareDef && !labwareEntities[labwareId]?.def) {
     throw new Error(
       `missing ${tab}_labware def for ${labwareId}, ` +
         `in labwareEntities: ${!!labwareEntities[labwareId]}`

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,9 @@ export const SecondStepsMoveLiquidTools = ({`
`171`	`171`	`]`
`172`	`172`	`)`
`173`	`173`	const labwareId = formData[`${tab}_labware`]
	`174`	`+ const shouldCheckLabwareDef = tab === 'aspirate' \|\| !isDestinationTrash`
`174`	`175`	`// The getMinXYDimension() call below is crashing quite often, but I'm not sure why`
`175`		`- if (!labwareEntities[labwareId]?.def) {`
	`176`	`+ if (shouldCheckLabwareDef && !labwareEntities[labwareId]?.def) {`
`176`	`177`	`throw new Error(`
`177`	`178`	`missing ${tab}_labware def for ${labwareId}, ` +
`178`	`179`	`in labwareEntities: ${!!labwareEntities[labwareId]}`