refactor(app): remove top-level calibration warning (#7036)

This removes the warning in the calibration card about robot calibration
being bad, since that confused people into thinking it meant only deck
calibration. It keeps the same logic about not displaying health check.

Author: sfoster1

app/src/components/RobotSettings/CalibrationCard.js

@@ -45,7 +45,6 @@ import {
 } from './constants'
 import { DeckCalibrationControl } from './DeckCalibrationControl'
 import { CheckCalibrationControl } from './CheckCalibrationControl'
-import { CalibrationCardWarning } from './CalibrationCardWarning'
 import { PipetteOffsets } from './PipetteOffsets'
 
 type Props = {|
@@ -152,12 +151,14 @@ export function CalibrationCard(props: Props): React.Node {
     )
   }
 
-  const warningInsteadOfCalcheck =
-    [
+  const displayCalCheck =
+    ![
       Calibration.DECK_CAL_STATUS_SINGULARITY,
       Calibration.DECK_CAL_STATUS_BAD_CALIBRATION,
       Calibration.DECK_CAL_STATUS_IDENTITY,
-    ].includes(deckCalStatus) || !pipetteCalPresent
+    ].includes(deckCalStatus) &&
+    pipetteCalPresent &&
+    pipettePresent
 
   const pipOffsetDataPresent = pipetteOffsetCalibrations
     ? pipetteOffsetCalibrations.length > 0
@@ -177,20 +178,17 @@ export function CalibrationCard(props: Props): React.Node {
         >
           {TITLE}
         </Text>
-        {!warningInsteadOfCalcheck ? (
-          <Link
-            href="#"
-            color={C_BLUE}
-            paddingTop={SPACING_3}
-            paddingX={SPACING_3}
-            fontSize={FONT_SIZE_BODY_1}
-            onClick={onClickSaveAs}
-          >
-            {DOWNLOAD_CALIBRATION}
-          </Link>
-        ) : null}
+        <Link
+          href="#"
+          color={C_BLUE}
+          paddingTop={SPACING_3}
+          paddingX={SPACING_3}
+          fontSize={FONT_SIZE_BODY_1}
+          onClick={onClickSaveAs}
+        >
+          {DOWNLOAD_CALIBRATION}
+        </Link>
       </Flex>
-      {warningInsteadOfCalcheck ? <CalibrationCardWarning /> : null}
       <DeckCalibrationControl
         robotName={robotName}
         disabledReason={buttonDisabledReason}
@@ -199,7 +197,7 @@ export function CalibrationCard(props: Props): React.Node {
         pipOffsetDataPresent={pipOffsetDataPresent}
       />
       <PipetteOffsets pipettesPageUrl={pipettesPageUrl} robot={robot} />
-      {!warningInsteadOfCalcheck && pipettePresent ? (
+      {displayCalCheck ? (
         <CheckCalibrationControl
           robotName={robotName}
           disabledReason={buttonDisabledReason}

app/src/components/RobotSettings/CalibrationCardWarning.js

@@ -13,7 +13,6 @@ import * as RobotSelectors from '../../../robot/selectors'
 
 import { CalibrationCard } from '../CalibrationCard'
 import { CheckCalibrationControl } from '../CheckCalibrationControl'
-import { CalibrationCardWarning } from '../CalibrationCardWarning'
 import { PipetteOffsets } from '../PipetteOffsets'
 import { mockAttachedPipette } from '../../../pipettes/__fixtures__'
 import { mockPipetteOffsetCalibration1 } from '../../../calibration/pipette-offset/__fixtures__'
@@ -257,27 +256,25 @@ describe('CalibrationCard', () => {
     Calibration.DECK_CAL_STATUS_BAD_CALIBRATION,
   ]
   cals.forEach(status => {
-    it(`CalibrationCardWarning component renders instead of check calibration if deck calibration is ${status}`, () => {
+    it(`check calibration does not render if deck calibration is ${status}`, () => {
       getDeckCalibrationStatus.mockImplementation((state, rName) => {
         expect(state).toEqual(MOCK_STATE)
         expect(rName).toEqual(mockRobot.name)
         return status
       })
       const { wrapper } = render()
 
-      expect(wrapper.exists(CalibrationCardWarning)).toBe(true)
       expect(wrapper.exists(CheckCalibrationControl)).toBe(false)
     })
   })
 
-  it('CalibrationCardWarning component renders instead of check calibration if pipette calibration is missing', () => {
+  it('check calibration does not render if pipette calibration is missing', () => {
     getAttachedPipetteCalibrations.mockReturnValue({
       left: { offset: null, tipLength: null },
       right: { offset: null, tipLength: null },
     })
     const { wrapper } = render()
 
-    expect(wrapper.exists(CalibrationCardWarning)).toBe(true)
     expect(wrapper.exists(CheckCalibrationControl)).toBe(false)
   })