Skip to content

Commit 5658b8a

Browse files
authored
fix(hardware): Fix the pressure sensor log from growing infinitely (#16338)
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview When looking at another bug I saw that this log was growing forever and this will eventually fill up the diskspace on the robot which is very bad. <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> ## Test Plan and Hands on Testing We can check that this file stays in the <1k range but honestly it would have shown up in bugs of the disk filling up. <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment Super low risk, doesn't effect the user at all. this is just a debugging log. <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
1 parent a6b3308 commit 5658b8a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

hardware/opentrons_hardware/sensors/sensor_driver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ def __init__(
243243

244244
async def __aenter__(self) -> None:
245245
"""Create a csv heading for logging pressure readings."""
246-
self.data_file = open(self.data_file, "a")
246+
self.data_file = open(self.data_file, "w")
247247
self.csv_writer = csv.writer(self.data_file)
248248
self.csv_writer.writerows([self.file_heading, self.sensor_metadata])
249249

0 commit comments

Comments
 (0)