refactor(protocol-designer): clean up navigation redux selectors and … (#17781)

…reducers

Author: jerader

protocol-designer/cypress/e2e/urlNavigation.cy.ts

@@ -6,7 +6,7 @@ describe('URL Navigation', () => {
   it('createNew', () => {
     cy.visit('#/createNew')
     // directly navigating sends you back to the home page
-    cy.verifyHomePage()
+    cy.verifyOnboardingPage()
   })
   it('overview', () => {
     cy.visit('#/overview')

protocol-designer/cypress/support/commands.ts

@@ -1,4 +1,5 @@
 import 'cypress-file-upload'
+import { SetupContent } from './SetupSteps'
 declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
   namespace Cypress {
@@ -34,6 +35,7 @@ declare global {
       mixaspirate: () => Cypress.Chainable<void>
       clickConfirm: () => Cypress.Chainable<void>
       verifyOverflowBtn: () => Cypress.Chainable<void>
+      verifyOnboardingPage: () => Cypress.Chainable<void>
     }
   }
 }
@@ -109,6 +111,14 @@ Cypress.Commands.add('verifyCreateNewHeader', () => {
   verifyUniversal()
 })
 
+// Onboarding page
+Cypress.Commands.add('verifyOnboardingPage', () => {
+  verifyUniversal()
+  cy.get(locators.privacyPolicy).should('exist').and('be.visible')
+  cy.get(locators.eula).should('exist').and('be.visible')
+  cy.contains(SetupContent.LetsGetStarted)
+})
+
 // Home Page
 Cypress.Commands.add('verifyHomePage', () => {
   cy.contains(content.welcome)

protocol-designer/src/navigation/index.ts

@@ -1,7 +1,6 @@
 import * as actions from './actions'
 import { rootReducer } from './reducers'
-import * as selectors from './selectors'
 import type { RootState } from './reducers'
 
-export { actions, rootReducer, selectors }
+export { actions, rootReducer }
 export type { RootState }

protocol-designer/src/navigation/reducers/index.ts

@@ -12,7 +12,6 @@ const newProtocolModal: Reducer<boolean, any> = handleActions(
       state,
       action: ToggleNewProtocolModalAction
     ): boolean => action.payload,
-    CREATE_NEW_PROTOCOL: () => false,
   },
   false
 )

protocol-designer/src/navigation/selectors.ts

@@ -1,5 +1,5 @@
 import * as Yup from 'yup'
-import { useEffect, useState } from 'react'
+import { useState } from 'react'
 import reduce from 'lodash/reduce'
 import omit from 'lodash/omit'
 import uniq from 'lodash/uniq'
@@ -39,7 +39,6 @@ import {
   createDeckFixture,
   toggleIsGripperRequired,
 } from '../../step-forms/actions/additionalItems'
-import { getNewProtocolModal } from '../../navigation/selectors'
 import { SelectModules } from '../../components/organisms/SelectModules'
 import { SelectRobot } from './SelectRobot'
 import { SelectPipettes } from './SelectPipettes'
@@ -157,7 +156,6 @@ const validationSchema: any = Yup.object().shape({
 
 export function CreateNewProtocolWizard(): JSX.Element | null {
   const navigate = useNavigate()
-  const showWizard = useSelector(getNewProtocolModal)
   const [analyticsStartTime] = useState<Date>(new Date())
   const customLabware = useSelector(
     labwareDefSelectors.getCustomLabwareDefsByURI
@@ -167,12 +165,6 @@ export function CreateNewProtocolWizard(): JSX.Element | null {
 
   const dispatch = useDispatch<ThunkDispatch<BaseState, any, any>>()
 
-  useEffect(() => {
-    if (!showWizard) {
-      navigate('/overview')
-    }
-  }, [showWizard])
-
   const createProtocolFile = (values: WizardFormState): void => {
     navigate('/overview')
 
@@ -382,7 +374,7 @@ export function CreateNewProtocolWizard(): JSX.Element | null {
     }
   }
 
-  return showWizard ? (
+  return (
     <Box backgroundColor={COLORS.grey10} height="calc(100vh - 48px)">
       <CreateFileForm
         currentWizardStep={currentWizardStep}
@@ -393,7 +385,7 @@ export function CreateNewProtocolWizard(): JSX.Element | null {
         analyticsStartTime={analyticsStartTime}
       />
     </Box>
-  ) : null
+  )
 }
 
 interface CreateFileFormProps {