feat(app): remove 2 track events (#18879)

* feat(app): remove 2 track events

Author: koji

app/src/organisms/ODD/QuickTransferFlow/QuickTransferAdvancedSettings/index.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react'
+import { useState } from 'react'
 import { useTranslation } from 'react-i18next'
 
 import {
@@ -19,8 +19,6 @@ import {
 } from '@opentrons/shared-data'
 
 import { useToaster } from '/app/organisms/ToasterOven'
-import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics'
-import { ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB } from '/app/redux/analytics'
 
 import { ACTIONS } from '../constants'
 import { AirGap } from './AirGap'
@@ -49,16 +47,8 @@ export function QuickTransferAdvancedSettings(
   const { state, dispatch } = props
   const { t, i18n } = useTranslation(['quick_transfer', 'shared'])
   const [selectedSetting, setSelectedSetting] = useState<string | null>(null)
-  const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial()
   const { makeSnackbar } = useToaster()
 
-  useEffect(() => {
-    trackEventWithRobotSerial({
-      name: ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB,
-      properties: {},
-    })
-  }, [])
-
   const getBlowoutValueCopy = (): string | undefined => {
     if (state.blowOutDispense?.location === 'dest_well') {
       return t('blow_out_into_destination_well')

app/src/organisms/ODD/QuickTransferFlow/TipManagement/index.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react'
+import { useState } from 'react'
 import { useTranslation } from 'react-i18next'
 
 import {
@@ -17,9 +17,6 @@ import {
 } from '@opentrons/components'
 import { TRASH_BIN_ADAPTER_FIXTURE } from '@opentrons/shared-data'
 
-import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics'
-import { ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB } from '/app/redux/analytics'
-
 import { ChangeTip } from './ChangeTip'
 import { TipDropLocation } from './TipDropLocation'
 
@@ -37,16 +34,8 @@ interface TipManagementProps {
 export function TipManagement(props: TipManagementProps): JSX.Element | null {
   const { state, dispatch } = props
   const { t } = useTranslation(['quick_transfer', 'shared'])
-  const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial()
   const [selectedSetting, setSelectedSetting] = useState<string | null>(null)
 
-  useEffect(() => {
-    trackEventWithRobotSerial({
-      name: ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB,
-      properties: {},
-    })
-  }, [])
-
   const displayItems = [
     {
       option: t('change_tip'),

app/src/organisms/ODD/QuickTransferFlow/__tests__/TipManagement/TipManagement.test.tsx

@@ -3,8 +3,6 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 import { renderWithProviders } from '/app/__testing-utils__'
 import { i18n } from '/app/i18n'
-import { useTrackEventWithRobotSerial } from '/app/redux-resources/analytics'
-import { ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB } from '/app/redux/analytics'
 
 import { TipManagement } from '../../TipManagement/'
 import { ChangeTip } from '../../TipManagement/ChangeTip'
@@ -14,14 +12,12 @@ import type { ComponentProps } from 'react'
 
 vi.mock('../../TipManagement/ChangeTip')
 vi.mock('../../TipManagement/TipDropLocation')
-vi.mock('/app/redux-resources/analytics')
 
 const render = (props: ComponentProps<typeof TipManagement>): any => {
   return renderWithProviders(<TipManagement {...props} />, {
     i18nInstance: i18n,
   })
 }
-let mockTrackEventWithRobotSerial: any
 
 describe('TipManagement', () => {
   let props: ComponentProps<typeof TipManagement>
@@ -36,12 +32,6 @@ describe('TipManagement', () => {
       } as any,
       dispatch: vi.fn(),
     }
-    mockTrackEventWithRobotSerial = vi.fn(
-      () => new Promise(resolve => resolve({}))
-    )
-    vi.mocked(useTrackEventWithRobotSerial).mockReturnValue({
-      trackEventWithRobotSerial: mockTrackEventWithRobotSerial,
-    })
   })
   afterEach(() => {
     vi.resetAllMocks()
@@ -53,10 +43,6 @@ describe('TipManagement', () => {
     screen.getByText('Once at the start of the transfer')
     screen.getByText('Tip drop location')
     screen.getByText('Trash bin')
-    expect(mockTrackEventWithRobotSerial).toHaveBeenCalledWith({
-      name: ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB,
-      properties: {},
-    })
   })
   it('renders Change tip component when seleted', () => {
     render(props)

app/src/redux/analytics/constants.ts

@@ -82,11 +82,6 @@ export const ANALYTICS_QUICK_TRANSFER_FLOW_STARTED = 'quickTransferFlowStarted'
 export const ANALYTICS_QUICK_TRANSFER_WELL_SELECTION_DURATION =
   'quickTransferWellSelectionDuration'
 export const ANALYTICS_QUICK_TRANSFER_EXIT_EARLY = 'quickTransferExitEarly'
-// ToDo(kk:04/11/2025) the following two tab events will be removed when ff is removed
-export const ANALYTICS_QUICK_TRANSFER_ADVANCED_SETTINGS_TAB =
-  'quickTransferAdvancedSettingsTab'
-export const ANALYTICS_QUICK_TRANSFER_TIP_MANAGEMENT_TAB =
-  'quickTransferTipManagementTab'
 export const ANALYTICS_QUICK_TRANSFER_SETTING_SAVED =
   'quickTransferSettingSaved'
 export const ANALYTICS_QUICK_TRANSFER_TIME_TO_CREATE =