Skip to content

Commit 7a0ee82

Browse files
authored
fix(analyses battery): PR generation bugs (#18952)
1 parent 203eeb4 commit 7a0ee82

File tree

4 files changed

+19
-1
lines changed

4 files changed

+19
-1
lines changed

.github/workflows/analyses-snapshot-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ jobs:
190190
title: 'fix(analyses-snapshot-testing): heal ${{ github.event.pull_request.head.ref }} snapshots'
191191
body: 'This PR was requested on the PR https://github.com/${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
192192
branch: 'analyses-snapshot-testing/heal-${{ github.event.pull_request.head.ref }}'
193-
base: ${{ github.event.pull_request.base.ref }}
193+
base: ${{ github.event.pull_request.head.ref }}
194194

195195
- name: Comment on feature PR
196196
if: always() && steps.create_pull_request.outcome == 'success' && github.event_name == 'pull_request'

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,4 @@ api/docs/dist/hardware/
154154
api/docs/dist/v2/
155155

156156
package-testing/results
157+
all_analysis_results/

analyses-snapshot-testing/files/protocols/Flex_S_v2_25_P200_stacker_2.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
from opentrons.protocol_api import COLUMN, ROW, ALL
44
import math
55

6+
from opentrons.protocol_api.core.engine import protocol
7+
68
metadata = {'protocolName': 'Illumina RNA Prep 96x Dev v1.1-5/2/2025','author': 'Opentrons <[email protected]>','source': 'Protocol Library',}
79
requirements = {"robotType": "Flex","apiLevel": "2.25",}
810

@@ -2287,3 +2289,4 @@ def nozzlecheck(nozzletype):
22872289
# =================================================================================================
22882290
# ========================================== PROTOCOL END =========================================
22892291
# =================================================================================================
2292+
protocol.comment("Done!!!")

analyses-snapshot-testing/tests/__snapshots__/analyses_snapshot_test/test_analysis_snapshot[c3b37eae0f][Flex_S_v2_25_P200_stacker_2].json

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57510,6 +57510,20 @@
5751057510
},
5751157511
"startedAt": "TIMESTAMP",
5751257512
"status": "succeeded"
57513+
},
57514+
{
57515+
"commandType": "comment",
57516+
"completedAt": "TIMESTAMP",
57517+
"createdAt": "TIMESTAMP",
57518+
"id": "UUID",
57519+
"key": "0067a8a21005e68bd26126d29bb4732c",
57520+
"notes": [],
57521+
"params": {
57522+
"message": "Done!!!"
57523+
},
57524+
"result": {},
57525+
"startedAt": "TIMESTAMP",
57526+
"status": "succeeded"
5751357527
}
5751457528
],
5751557529
"config": {

0 commit comments

Comments
 (0)