Skip to content

Commit 933ad22

Browse files
change reqs for easy stuff
1 parent 58bf071 commit 933ad22

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

api/src/opentrons/protocol_engine/state/geometry.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -588,11 +588,11 @@ def validate_probed_height(
588588
f"Liquid Height of {probed_height} mm is greater than maximum well height {well_depth} mm."
589589
)
590590

591-
def get_xy_offset_if_needed(self, labware_id: str, well_name: str) -> WellOffset:
591+
def _get_xy_offset_if_needed(self, labware_id: str, well_name: str) -> Point:
592592
"""Add an x,y offset to position the tip into the center of a sub-well if needed."""
593593
labware_definition = self._labware.get_definition(labware_id)
594594
if labware_definition.innerLabwareGeometry is None:
595-
return WellOffset(x=0, y=0, z=0)
595+
return Point(x=0, y=0, z=0)
596596
well_def = self._labware.get_well_definition(labware_id, well_name)
597597
well_geometry = self._labware.get_well_geometry(
598598
labware_id=labware_id, well_name=well_name
@@ -609,7 +609,6 @@ def get_xy_offset_if_needed(self, labware_id: str, well_name: str) -> WellOffset
609609
if well_def.shape == "circular":
610610
well_x_dimension = well_y_dimension = well_def.diameter
611611
else:
612-
assert well_def.shape == "rectangular", "invalid well shape"
613612
well_x_dimension = well_def.xDimension
614613
well_y_dimension = well_def.yDimension
615614

@@ -623,7 +622,7 @@ def get_xy_offset_if_needed(self, labware_id: str, well_name: str) -> WellOffset
623622
subsection_y_dimension = well_y_dimension / bottom_ycount
624623
# move over into the middle of the nearest subection
625624
y_offset = subsection_y_dimension / 2
626-
return WellOffset(x=x_offset, y=y_offset, z=0)
625+
return Point(x=x_offset, y=y_offset, z=0)
627626

628627
def get_well_position(
629628
self,
@@ -637,7 +636,7 @@ def get_well_position(
637636
labware_pos = self.get_labware_position(labware_id)
638637
well_def = self._labware.get_well_definition(labware_id, well_name)
639638
well_depth = well_def.depth
640-
xy_offset = self.get_xy_offset_if_needed(
639+
xy_offset = self._get_xy_offset_if_needed(
641640
labware_id=labware_id, well_name=well_name
642641
)
643642
offset = WellOffset(x=xy_offset.x, y=xy_offset.y, z=well_depth)

0 commit comments

Comments
 (0)