Skip to content

Commit 9964abd

Browse files
refactor(shared-data): Delete twoDimensionalRendering from module definitions (#18853)
This deletes some dead code in module definitions. These JSON definitions had SVG graphics embedded in them via [svgson](https://github.com/elrumordelaluz/svgson). We have apparently not used these in a while; we instead favor defining SVGs in `.tsx` files instead, e.g. `components/src/hardware-sim/Module/HeaterShaker.tsx`.
1 parent 40dd787 commit 9964abd

File tree

25 files changed

+9
-7838
lines changed

25 files changed

+9
-7838
lines changed

api/tests/opentrons/conftest.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,6 @@ def minimal_module_def() -> ModuleDefinitionV3:
809809
"slotTransforms": {},
810810
"compatibleWith": ["temperatureModuleV2"],
811811
"cornerOffsetFromSlot": {"x": 0.1, "y": 0.1, "z": 0.0},
812-
"twoDimensionalRendering": {},
813812
}
814813

815814

api/tests/opentrons/protocol_api/core/legacy/test_module_geometry.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ def v1_mag_module_schema_v3_definition() -> ModuleDefinitionV3:
4646
"slotTransforms": {},
4747
"compatibleWith": ["someSimilarModule"], # type: ignore[list-item]
4848
"cornerOffsetFromSlot": {"x": 111, "y": 222, "z": 333},
49-
"twoDimensionalRendering": {},
5049
"config": {},
5150
}
5251

@@ -73,7 +72,6 @@ def minimal_heater_shaker_definition() -> ModuleDefinitionV3:
7372
"slotTransforms": {},
7473
"compatibleWith": ["someSimilarModule"], # type: ignore[list-item]
7574
"cornerOffsetFromSlot": {"x": 111, "y": 222, "z": 333},
76-
"twoDimensionalRendering": {},
7775
"config": {},
7876
}
7977

app/src/organisms/Desktop/Devices/ProtocolRun/SetupLabware/__tests__/LabwareListItem.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ const mockLocationInfo = {
4444
labwareInterfaceXDimension: 80,
4545
labwareInterfaceYDimension: 120,
4646
},
47-
twoDimensionalRendering: { children: [] },
4847
}
4948
const mockAttachedModuleInfo = {
5049
x: 1,

app/src/organisms/Desktop/Devices/ProtocolRun/SetupLabware/__tests__/SetupLabwareMap.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ const mockMagneticModule = {
6969
labwareInterfaceXDimension: 80,
7070
labwareInterfaceYDimension: 120,
7171
},
72-
twoDimensionalRendering: { children: [] },
7372
quirks: [],
7473
}
7574

app/src/organisms/Desktop/Devices/ProtocolRun/SetupModuleAndDeck/__tests__/SetupModulesList.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ const mockMagneticModule = {
5858
calibrationPoint: { x: 0, y: 0 },
5959
displayName: 'Magnetic Module',
6060
dimensions: {},
61-
twoDimensionalRendering: { children: [] },
6261
quirks: [],
6362
}
6463

app/src/organisms/Desktop/Devices/ProtocolRun/SetupModuleAndDeck/__tests__/SetupModulesMap.test.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ const mockMagneticModule = {
7878
labwareInterfaceXDimension: 80,
7979
labwareInterfaceYDimension: 120,
8080
},
81-
twoDimensionalRendering: { children: [] },
8281
}
8382

8483
const mockTCModule = {
@@ -95,7 +94,6 @@ const mockTCModule = {
9594
labwareInterfaceXDimension: 80,
9695
labwareInterfaceYDimension: 120,
9796
},
98-
twoDimensionalRendering: { children: [] },
9997
}
10098

10199
describe('SetupModulesMap', () => {

0 commit comments

Comments
 (0)