Skip to content

Commit b5bf1c7

Browse files
authored
fix(protocol-designer): avoid StepList exception on keydown (#7442)
- No longer ignore exceptions in TC e2e test(this is the test that often fails on Mac in CI)
1 parent 061a580 commit b5bf1c7

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

protocol-designer/cypress/integration/newProtocolWithTC.spec.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,6 @@ describe('Protocols with Modules', () => {
9191
})
9292

9393
it('designs protocol with thermocycler', () => {
94-
// Avoid failing the test on uncaught exception
95-
// Happens when writing a nickname for the labware
96-
Cypress.on('uncaught:exception', (err, runnable) => {
97-
console.log(err.name)
98-
return false
99-
})
100-
10194
cy.openDesignPage()
10295
// close "setting up" modal
10396
cy.contains('Setting up your protocol').should('exist')

protocol-designer/src/components/steplist/StepList.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class StepList extends React.Component<Props> {
2525
handleKeyDown: (e: SyntheticKeyboardEvent<>) => void = e => {
2626
const { reorderSelectedStep } = this.props
2727
const key = e.key
28-
const altIsPressed = e.getModifierState('Alt')
28+
const altIsPressed = e.altKey
2929

3030
if (altIsPressed) {
3131
let delta = 0

0 commit comments

Comments
 (0)