Skip to content

Commit bbf819b

Browse files
authored
fix(protocol-designer): fix addfixture modal width and update text in add pause modal (#19086)
* fix(protocol-designer): fix addfixture modal width and update text in add pause modal
1 parent 822c32e commit bbf819b

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

protocol-designer/cypress/support/ModuleSteps.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export const ModuleSteps = {
101101
*/
102102
PauseAfterSettingTempdeck: (): StepThunk => ({
103103
call: () => {
104-
cy.contains(ModLocators.Button, 'Pause protocol')
104+
cy.contains(ModLocators.Button, 'Add pause step')
105105
.should('exist')
106106
.and('be.visible')
107107
.click()

protocol-designer/src/assets/localization/en/modal.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,14 @@
103103
"body1": "Pause protocol now to wait until module reaches {{temperature}}°C before continuing on to the next step.",
104104
"body2": "Build a pause later if you want your protocol to proceed to the next steps while the temperature module ramps up to {{temperature}}°C.",
105105
"heater_shaker_pause_later": "Build a pause later if you want your protocol to proceed to the next steps while the Heater-Shaker module goes to {{temperature}}°C",
106-
"heater_shaker_title": "Pause protocol until Heater-Shaker module is at {{temperature}}°C?",
106+
"heater_shaker_title": "Pause protocol until Heater-Shaker module reaches {{temperature}}°C",
107107
"later_button": "I will build a pause later",
108108
"now_button": "Pause protocol now",
109109
"redesign": {
110-
"body1": "Build a pause step to wait until {{module}} reaches {{temp}}°C before continuing to the next step.",
111-
"body2": "Build a pause step later if you want your protocol to proceed to the next step while the {{module}} goes to {{temp}}°C",
112-
"build_pause_later": "Build pause later",
113-
"pause_protocol": "Pause protocol",
114-
"title": "Pause protocol until {{module}} is at {{temp}}°C"
110+
"body": "Add a pause step to wait until the {{module}} reaches {{temperature}}°C. Click Skip to continue to the next protocol step without pausing.",
111+
"skip_pause_step": "Skip pause step",
112+
"add_pause_step": "Add pause step",
113+
"title": "Pause protocol until {{module}} reaches {{temp}}°C?"
115114
},
116115
"title": "Pause protocol until temperature module is at {{temperature}}°C?"
117116
},

protocol-designer/src/components/organisms/AutoAddPauseUntilTempStepModal/index.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,26 +50,20 @@ export const AutoAddPauseUntilTempStepModal = (
5050
>
5151
<SecondaryButton onClick={handleCancelClick}>
5252
<StyledText desktopStyle="bodyDefaultSemiBold">
53-
{t('auto_add_pause_until_temp_step.redesign.build_pause_later')}
53+
{t('auto_add_pause_until_temp_step.redesign.skip_pause_step')}
5454
</StyledText>
5555
</SecondaryButton>
5656
<PrimaryButton onClick={handleContinueClick}>
5757
<StyledText desktopStyle="bodyDefaultSemiBold">
58-
{t('auto_add_pause_until_temp_step.redesign.pause_protocol')}
58+
{t('auto_add_pause_until_temp_step.redesign.add_pause_step')}
5959
</StyledText>
6060
</PrimaryButton>
6161
</Flex>
6262
}
6363
>
6464
<Flex gridGap={SPACING.spacing8} flexDirection={DIRECTION_COLUMN}>
6565
<StyledText desktopStyle="bodyDefaultRegular">
66-
{t('auto_add_pause_until_temp_step.redesign.body1', {
67-
module: displayModule,
68-
temp: displayTemperature,
69-
})}
70-
</StyledText>
71-
<StyledText desktopStyle="bodyDefaultRegular">
72-
{t('auto_add_pause_until_temp_step.redesign.body2', {
66+
{t('auto_add_pause_until_temp_step.redesign.body', {
7367
module: displayModule,
7468
temp: displayTemperature,
7569
})}

protocol-designer/src/components/organisms/HardwareConfigurator/AddFixtureModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export function AddFixtureModal(props: AddFixtureModalProps): JSX.Element {
120120
onClose: closeModal,
121121
closeOnOutsideClick: true,
122122
childrenPadding: SPACING.spacing24,
123-
width: '26.75rem',
123+
width: '28.75rem',
124124
}
125125

126126
const availableOptions = getAvailableOptions({ optionStage, cutoutId })

0 commit comments

Comments
 (0)