Skip to content

Commit bd2b0ac

Browse files
authored
chore(app-shell): disable windows signing better (#18550)
Setting forceCodeSigning=false means that builds won't fail if "the app would not be signed", but I think that means "if you haven't specified signing details", not "the shell call to sign the executables fails" - if the latter happens, the build fails anyway. So if we're not signing, just don't even specify the sign options.
1 parent a13a387 commit bd2b0ac

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

app-shell/electron-builder.config.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,14 @@ module.exports = async () => ({
6767
target: ['nsis'],
6868
icon: project === 'robot-stack' ? 'build/icon.ico' : 'build/three.ico',
6969
forceCodeSigning: WINDOWS_SIGN,
70-
azureSignOptions: {
71-
publisherName: 'OPENTRONS LABWORKS INC.',
72-
codeSigningAccountName: 'desktop-app-signing',
73-
certificateProfileName: 'OpentronsDesktopApp',
74-
endpoint: 'https://eus.codesigning.azure.net',
75-
},
70+
azureSignOptions: WINDOWS_SIGN
71+
? {
72+
publisherName: 'OPENTRONS LABWORKS INC.',
73+
codeSigningAccountName: 'desktop-app-signing',
74+
certificateProfileName: 'OpentronsDesktopApp',
75+
endpoint: 'https://eus.codesigning.azure.net',
76+
}
77+
: undefined,
7678
},
7779
nsis: {
7880
oneClick: false,

0 commit comments

Comments
 (0)