Skip to content

Commit cb8ffd9

Browse files
authored
fix(protocol-designer): widen well visual images to fix modal (#18850)
closes RQA-4340
1 parent 2281d8d commit cb8ffd9

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

protocol-designer/src/components/organisms/TipPositionModal/TipPositionSideView.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import BOTTOM_LAYER from '../../../assets/images/tip_side_bottom_layer.svg'
1414
import MID_LAYER from '../../../assets/images/tip_side_mid_layer.svg'
1515
import TOP_LAYER from '../../../assets/images/tip_side_top_layer.svg'
1616

17-
const WELL_HEIGHT_PIXELS = 71
18-
const WELL_WIDTH_PIXELS = 70
17+
const WELL_HEIGHT_PIXELS = 78
18+
const WELL_WIDTH_PIXELS = 80
1919
const PIXEL_DECIMALS = 2
2020

2121
interface TipPositionAllVizProps {
@@ -44,8 +44,8 @@ export function TipPositionSideView(
4444
return (
4545
<Box
4646
position={POSITION_RELATIVE}
47-
width="15.8125rem"
48-
height="18rem"
47+
width="20.75rem"
48+
height="22.75rem"
4949
overflow={OVERFLOW_HIDDEN}
5050
>
5151
<img
@@ -58,7 +58,7 @@ export function TipPositionSideView(
5858
style={{
5959
position: POSITION_ABSOLUTE,
6060
transform: `translate(${roundedXPositionPixels}px)`,
61-
bottom: `calc(${bottomPx}px + 33px)`,
61+
bottom: `calc(${bottomPx}px + 10px)`,
6262
}}
6363
alt="mid layer"
6464
/>
@@ -68,15 +68,15 @@ export function TipPositionSideView(
6868
alt="top layer"
6969
/>
7070
{wellDepthMm !== null && (
71-
<Box position={POSITION_ABSOLUTE} bottom="7.3rem" right="2rem">
71+
<Box position={POSITION_ABSOLUTE} top="12.5rem" right="3.5rem">
7272
<StyledText desktopStyle="captionRegular" color={COLORS.grey60}>
7373
{round(wellDepthMm, 0)}
7474
{t('units.millimeter')}
7575
</StyledText>
7676
</Box>
7777
)}
7878
{xWidthMm !== null && (
79-
<Box position={POSITION_ABSOLUTE} bottom="2rem" right="7rem">
79+
<Box position={POSITION_ABSOLUTE} bottom="2rem" right="9.6rem">
8080
<StyledText desktopStyle="captionRegular" color={COLORS.grey60}>
8181
{xWidthMm}
8282
{t('units.millimeter')}

protocol-designer/src/components/organisms/TipPositionModal/TipPositionTopView.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import BOTTOM_LAYER from '../../../assets/images/tip_top_bottom_layer.svg'
1414
import MID_LAYER from '../../../assets/images/tip_top_mid_layer.svg'
1515
import TOP_LAYER from '../../../assets/images/tip_top_top_layer.svg'
1616

17-
const WELL_WIDTH_PIXELS = 70
17+
const WELL_WIDTH_PIXELS = 110
1818
const PIXEL_DECIMALS = 2
1919

2020
interface TipPositionAllVizProps {
@@ -37,8 +37,8 @@ export function TipPositionTopView(props: TipPositionAllVizProps): JSX.Element {
3737
return (
3838
<Box
3939
position={POSITION_RELATIVE}
40-
width="15.8125rem"
41-
height="18rem"
40+
width="20.75rem"
41+
height="22.75rem"
4242
overflow={OVERFLOW_HIDDEN}
4343
>
4444
<img
@@ -60,7 +60,7 @@ export function TipPositionTopView(props: TipPositionAllVizProps): JSX.Element {
6060
alt="top layer"
6161
/>
6262
{xWidthMm !== null && (
63-
<Box position={POSITION_ABSOLUTE} bottom="2rem" right="7rem">
63+
<Box position={POSITION_ABSOLUTE} bottom="3.5rem" right="9.2rem">
6464
<StyledText desktopStyle="captionRegular" color={COLORS.grey60}>
6565
{xWidthMm}
6666
{t('units.millimeter')}

protocol-designer/src/components/organisms/TipPositionModal/index.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
ALIGN_CENTER,
77
Banner,
88
Btn,
9+
COLORS,
910
DIRECTION_COLUMN,
1011
Flex,
1112
InputField,
@@ -408,6 +409,7 @@ export function TipPositionModal(
408409
{t(`modal:tip_position.view.${view}`)}
409410
</StyledText>
410411
<Btn
412+
color={COLORS.grey60}
411413
fontWeight={TYPOGRAPHY.fontWeightSemiBold}
412414
css={LINK_BUTTON_STYLE}
413415
onClick={() => {

0 commit comments

Comments
 (0)