robot.run and robot.simulate re-raise exceptions instead of adding ro… (#159)

* robot.run and robot.simulate re-raise exceptions instead of adding robot warnings list

* tests exceptions during robot run

Author: andySigler

opentrons/robot/robot.py

@@ -766,8 +766,9 @@ def run(self, **kwargs):
                     'name': 'command-failed',
                     'error': str(e)
                 })
-                self.add_warning(str(e))
-                break
+                raise RuntimeError(
+                    'Command #{0} failed (\"{1}\"").\nError: \"{2}\"'.format(
+                        i, command.description, str(e))) from e
 
         return self._runtime_warnings
 

tests/opentrons/protocol/test_robot.py

@@ -62,7 +62,7 @@ def test_stop_run(self):
 
         def _run():
             nonlocal res
-            res = self.robot.run()
+            self.assertRaises(RuntimeError(self.robot.run))
 
         thread = threading.Thread(target=_run)
         thread.start()
@@ -71,8 +71,17 @@ def _run():
 
         thread.join()
 
-        self.assertEquals(
-            res[-1], 'Received a STOP signal and exited from movements')
+    def test_exceptions_during_run(self):
+        p200 = instruments.Pipette(axis='b', name='my-fancy-pancy-pipette')
+
+        def _do():
+            return 'hello' / 3
+
+        p200.create_command(
+            do=_do,
+            enqueue=True)
+
+        self.assertRaises(RuntimeError, self.robot.run)
 
     def test_calibrated_max_dimension(self):