Skip to content

Commit e86f61b

Browse files
authored
fix(protocol-designer): thermocycler caption and error copy (#18922)
This PR updates the lid and block temperature range captions to match designs. It also updates the error copy to display "Enter a value within the specified range" whether the relevant temperature field is empty, or it is entered but out of range. Closes RQA-4195
1 parent 039e35d commit e86f61b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

protocol-designer/src/assets/localization/en/protocol_steps.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"blowout_location": "Blowout location",
1616
"blowout_position": "Blowout position from top",
1717
"captions_for_fields": {
18-
"blockTargetTemp": "Must be between 4 and 99˚C",
19-
"lidTargetTemp": "Must be between 37 and 110˚C",
18+
"blockTargetTemp": "Valid range between 4 and 99˚C",
19+
"lidTargetTemp": "Valid range between 37 and 110˚C",
2020
"targetSpeed": "Must be between 200 and 3000 rpm",
2121
"targetTemperature": "Must be between 4 and 95˚C",
2222
"targetHeaterShakerTemperature": "Must be between 37 and 95˚C",

protocol-designer/src/steplist/formLevel/errors.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,31 +173,31 @@ const PROFILE_VOLUME_REQUIRED: FormError = {
173173
page: 1,
174174
}
175175
const PROFILE_LID_TEMPERATURE_REQUIRED: FormError = {
176-
title: 'Temperature required',
176+
title: RANGE_TITLE,
177177
dependentFields: ['thermocyclerFormType', 'profileTargetLidTemp'],
178178
location: 'field',
179179
page: 1,
180180
}
181181
const LID_TEMPERATURE_REQUIRED: FormError = {
182-
title: 'Temperature required',
182+
title: RANGE_TITLE,
183183
dependentFields: ['lidIsActive', 'lidTargetTemp'],
184184
location: 'field',
185185
page: 1,
186186
}
187187
const BLOCK_TEMPERATURE_REQUIRED: FormError = {
188-
title: 'Temperature required',
188+
title: RANGE_TITLE,
189189
dependentFields: ['blockIsActive', 'blockTargetTemp'],
190190
location: 'field',
191191
page: 1,
192192
}
193193
const BLOCK_TEMPERATURE_HOLD_REQUIRED: FormError = {
194-
title: 'Temperature required',
194+
title: RANGE_TITLE,
195195
dependentFields: ['blockIsActiveHold', 'blockTargetTempHold'],
196196
location: 'field',
197197
page: 1,
198198
}
199199
const LID_TEMPERATURE_HOLD_REQUIRED: FormError = {
200-
title: 'Temperature required',
200+
title: RANGE_TITLE,
201201
dependentFields: ['lidIsActiveHold', 'lidTargetTempHold'],
202202
location: 'field',
203203
page: 1,

0 commit comments

Comments
 (0)