Skip to content

Commit ff5e0c0

Browse files
authored
fix(api): remove homing patch fix for right mount when a 96-channel is attached (#14975)
<!-- Thanks for taking the time to open a pull request! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview We now [unconditionally home the axis](#14955) before performing the homing move so we can now remove this patch. If we leave this in, the head R is going to raise an error when the robot boots up the first time because it will not be able to update the position estimation. <!-- Use this section to describe your pull-request at a high level. If the PR addresses any open issues, please tag the issues here. --> # Test Plan <!-- Use this section to describe the steps that you took to test your Pull Request. If you did not perform any testing provide justification why. OT-3 Developers: You should default to testing on actual physical hardware. Once again, if you did not perform testing against hardware, justify why. Note: It can be helpful to write a test plan before doing development Example Test Plan (HTTP API Change) - Verified that new optional argument `dance-party` causes the robot to flash its lights, move the pipettes, then home. - Verified that when you omit the `dance-party` option the robot homes normally - Added protocol that uses `dance-party` argument to G-Code Testing Suite - Ran protocol that did not use `dance-party` argument and everything was successful - Added unit tests to validate that changes to pydantic model are correct --> # Changelog <!-- List out the changes to the code in this PR. Please try your best to categorize your changes and describe what has changed and why. Example changelog: - Fixed app crash when trying to calibrate an illegal pipette - Added state to API to track pipette usage - Updated API docs to mention only two pipettes are supported IMPORTANT: MAKE SURE ANY BREAKING CHANGES ARE PROPERLY COMMUNICATED --> # Review requests <!-- Describe any requests for your reviewers here. --> # Risk assessment <!-- Carefully go over your pull request and look at the other parts of the codebase it may affect. Look for the possibility, even if you think it's small, that your change may affect some other part of the system - for instance, changing return tip behavior in protocol may also change the behavior of labware calibration. Identify the other parts of the system your codebase may affect, so that in addition to your own review and testing, other people who may not have the system internalized as much as you can focus their attention and testing there. -->
1 parent 433ef44 commit ff5e0c0

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

api/src/opentrons/hardware_control/ot3api.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,14 +1521,8 @@ async def _home_axis(self, axis: Axis) -> None:
15211521
# G, Q should be handled in the backend through `self._home()`
15221522
assert axis not in [Axis.G, Axis.Q]
15231523

1524-
# TODO(CM): This is a temporary fix in response to the right mount causing
1525-
# errors while trying to home on startup or attachment. We should remove this
1526-
# when we fix this issue in the firmware.
1527-
enable_right_mount_on_startup = (
1528-
self._gantry_load == GantryLoad.HIGH_THROUGHPUT and axis == Axis.Z_R
1529-
)
15301524
encoder_ok = self._backend.check_encoder_status([axis])
1531-
if encoder_ok or enable_right_mount_on_startup:
1525+
if encoder_ok:
15321526
# enable motor (if needed) and update estimation
15331527
await self._enable_before_update_estimation(axis)
15341528

0 commit comments

Comments
 (0)