From 43515c3a53cd125b38accc6388d3194d6e2dba35 Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Wed, 6 Aug 2025 11:43:55 -0400 Subject: [PATCH 1/2] fix(app): reset RTP capture if analysis changes The ChooseRobotToRunProtocolSlideout needed to reset its react state that captures the RTP value overrides, since it doesn't get unmounted if you alter the protocol and reanalyze it. Sad. Closes RQA-4496 --- .../Desktop/ChooseRobotToRunProtocolSlideout/index.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx b/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx index 0c4ba81cfef..cdc3540817e 100644 --- a/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx +++ b/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx @@ -1,4 +1,4 @@ -import { useState } from 'react' +import { useEffect, useState } from 'react' import { useTranslation } from 'react-i18next' import { useNavigate } from 'react-router-dom' import first from 'lodash/first' @@ -94,6 +94,9 @@ export function ChooseRobotToRunProtocolSlideoutComponent( const [hasMissingFileParam, setHasMissingFileParam] = useState( runTimeParameters?.some(parameter => parameter.type === 'csv_file') ?? false ) + useEffect(() => setRunTimeParametersOverrides(runTimeParameters), [ + storedProtocolData, + ]) const [targetProps, tooltipProps] = useHoverTooltip() From 3192c689015cc938e0c912e415f7591e2fc2d32e Mon Sep 17 00:00:00 2001 From: Seth Foster Date: Wed, 6 Aug 2025 12:24:49 -0400 Subject: [PATCH 2/2] delint --- .../Desktop/ChooseRobotToRunProtocolSlideout/index.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx b/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx index cdc3540817e..8ae48967efa 100644 --- a/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx +++ b/app/src/organisms/Desktop/ChooseRobotToRunProtocolSlideout/index.tsx @@ -94,9 +94,9 @@ export function ChooseRobotToRunProtocolSlideoutComponent( const [hasMissingFileParam, setHasMissingFileParam] = useState( runTimeParameters?.some(parameter => parameter.type === 'csv_file') ?? false ) - useEffect(() => setRunTimeParametersOverrides(runTimeParameters), [ - storedProtocolData, - ]) + useEffect(() => { + setRunTimeParametersOverrides(runTimeParameters) + }, [storedProtocolData]) const [targetProps, tooltipProps] = useHoverTooltip()