Raise error when advisory lock cannot be acquired #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
2 times, most recently
from
398e520 to
5787303
Compare
kenrose
reviewed
Mar 19, 2025
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
3 times, most recently
from
f213213 to
d9749ba
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
2 times, most recently
from
81a4b14 to
618ef8a
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
4 times, most recently
from
466b321 to
cad9d07
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
from
83e3782 to
a21a037
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
from
a21a037 to
0e6fbf5
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
from
d9249be to
ef54cd3
Compare
Farjaad
force-pushed
the
13122-raise-error-if-we-cant-get-lock
branch
from
ef54cd3 to
ae7b44f
Compare
eapache-opslevel
approved these changes
Mar 20, 2025
|
ahh I forgot to squash my commits 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab Issue: https://gitlab.com/jklabsinc/OpsLevel/-/issues/13122
I found traces where jobs fail with a lock timeout after 50s when inserting into
entity_node_hierarchyso that means our jobs do fail if the actual insert is taking long.But there are traces (example) where the job sits for minutes just doing
SELECT GET_LOCKuntil it gets shutdown by sidekiq. TheSELECT GET_LOCKcomes from the closure_tree gem and the gem always callswith_advisory_lockwithout any options which means that it waits indefinitely for the lock.So this MR uses
with_advisory_lock!so that it raises an error if we can't get the lock instead of just waiting indefinitely so that the jobs will end up in the dead set if there's a lot of contention. https://github.com/ClosureTree/with_advisory_lock/blob/master/lib/with_advisory_lock/concern.rb#L16