fix stream crash

Author: OptimusPi

Motely/MotelySingleSearchContext.Jokers.cs

@@ -137,6 +137,7 @@ public MotelySingleItemSet GetNextBuffoonPackContents(ref MotelySingleJokerStrea
 
     public MotelySingleItemSet GetNextBuffoonPackContents(ref MotelySingleJokerStream jokerStream, int size)
     {
+        Debug.Assert(!jokerStream.RarityPrngStream.IsInvalid, "Joker stream must have valid rarity PRNG");
         Debug.Assert(size <= MotelySingleItemSet.MaxLength);
 
         MotelySingleItemSet pack = new();

Motely/Program.cs

@@ -50,7 +50,7 @@ static int Main(string[] args)
 
             var cutoffOption = app.Option<string>(
                 "--cutoff <SCORE>",
-                "Minimum TotalScore threshold (1-10 for fixed, 0 for auto-cutoff)",
+                "Minimum TotalScore threshold (0+ for fixed, 'auto' for auto-cutoff)",
                 CommandOptionType.SingleValue);
             cutoffOption.DefaultValue = "0";
 
@@ -149,9 +149,9 @@ static int Main(string[] args)
                 var batchSize = batchSizeOption.ParsedValue;
                 var enableDebug = debugOption.HasValue();
                 var cutoffStr = cutoffOption.Value() ?? "0";
-                int cutoffValue = int.TryParse(cutoffStr, out var c) ? c : 0;
-                bool autoCutoff = cutoffValue == 0;  // 0 means auto-cutoff
-                int cutoff = autoCutoff ? 1 : cutoffValue;  // Start at 1 for auto-cutoff
+                bool autoCutoff = cutoffStr.ToLowerInvariant() == "auto";
+                int cutoffValue = autoCutoff ? 1 : (int.TryParse(cutoffStr, out var c) ? c : 0);
+                int cutoff = cutoffValue;  // Use the parsed value or 1 for auto
 
                 // Validate batch ranges based on search space
                 ulong maxBatches = (ulong)Math.Pow(35, 8 - batchSize); // 35^(8-batchSize)

Motely/filters/MotelyJson/MotelyJsonFilterDesc.cs

@@ -234,32 +234,35 @@ private VectorMask FilterJokers(ref MotelyVectorSearchContext ctx)
             if (clauses.Count == 1 && clauses[0].ItemTypeEnum == MotelyFilterItemType.SoulJoker && 
                 clauses[0].JokerEnum == MotelyJoker.Perkeo)
             {
+                // Capture clause to avoid closure issues
+                var perkeoClause = clauses[0];
+                var effectiveAntes = perkeoClause.EffectiveAntes ?? new[] { 1, 2, 3, 4, 5, 6, 7, 8 };
                 return ctx.SearchIndividualSeeds((ref MotelySingleSearchContext singleCtx) =>
                 {
                     // Fast path for Perkeo check
-                    foreach (var ante in clauses[0].EffectiveAntes)
+                    foreach (var ante in effectiveAntes)
                     {
-                        var packStream = singleCtx.CreateBoosterPackStream(ante, ante != 1, false);
+                        var packStream = singleCtx.CreateBoosterPackStream(ante, ante != 1, isCached: true);
                         for (int i = 0; i < 4; i++) // Check first 4 packs
                         {
                             var pack = singleCtx.GetNextBoosterPack(ref packStream);
 
                             if (pack.GetPackType() == MotelyBoosterPackType.Arcana)
                             {
-                                var tarotStream = singleCtx.CreateArcanaPackTarotStream(ante, true);
+                                var tarotStream = singleCtx.CreateArcanaPackTarotStream(ante, soulOnly: true, isCached: true);
                                 if (singleCtx.GetNextArcanaPackHasTheSoul(ref tarotStream, pack.GetPackSize()))
                                 {
-                                    var soulStream = singleCtx.CreateSoulJokerStream(ante);
+                                    var soulStream = singleCtx.CreateSoulJokerStream(ante, isCached: true);
                                     if (singleCtx.GetNextJoker(ref soulStream).Type == MotelyItemType.Perkeo)
                                         return true;
                                 }
                             }
                             else if (pack.GetPackType() == MotelyBoosterPackType.Spectral)
                             {
-                                var spectralStream = singleCtx.CreateSpectralPackSpectralStream(ante, true);
+                                var spectralStream = singleCtx.CreateSpectralPackSpectralStream(ante, soulOnly: true, isCached: true);
                                 if (singleCtx.GetNextSpectralPackHasTheSoul(ref spectralStream, pack.GetPackSize()))
                                 {
-                                    var soulStream = singleCtx.CreateSoulJokerStream(ante);
+                                    var soulStream = singleCtx.CreateSoulJokerStream(ante, isCached: true);
                                     if (singleCtx.GetNextJoker(ref soulStream).Type == MotelyItemType.Perkeo)
                                         return true;
                                 }

Motely/filters/MotelyJson/MotelyJsonScoring.cs

@@ -324,6 +324,7 @@ public static int CountJokerOccurrences(ref MotelySingleSearchContext ctx, Motel
         if (clause.Sources?.PackSlots?.Length > 0)
         {
             var buffoonStream = ctx.CreateBuffoonPackJokerStream(ante);
+            Debug.Assert(!buffoonStream.RarityPrngStream.IsInvalid, $"BuffoonStream RarityPrng should be valid for ante {ante}");
             var packSlots = clause.Sources.PackSlots;
             int maxPackSlot = clause.MaxPackSlot ?? (packSlots.Length > 0 ? packSlots.Max() : 0);
             for (int i = 0; i <= maxPackSlot; i++)